Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: sqlite for vm spec storage #1028

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

wip: sqlite for vm spec storage #1028

wants to merge 1 commit into from

Conversation

richardcase
Copy link
Member

What this PR does / why we need it:

Change flintlock to use sqlite for storing the microvmn specs instead of containerd. This will help with querying etc,

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@richardcase richardcase added the kind/feature New feature or request label Feb 16, 2025
Copy link

netlify bot commented Feb 16, 2025

Deploy Preview for flintlock-docs ready!

Name Link
🔨 Latest commit a6c3035
🔍 Latest deploy log https://app.netlify.com/sites/flintlock-docs/deploys/67b1e892ecbd8b0008c7f2ce
😎 Deploy Preview https://deploy-preview-1028--flintlock-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 253 lines in your changes missing coverage. Please review.

Project coverage is 36.27%. Comparing base (dde7055) to head (a6c3035).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
infrastructure/sqlite/repository.go 0.00% 171 Missing ⚠️
internal/command/run/run.go 0.00% 36 Missing ⚠️
infrastructure/sqlite/migration.go 0.00% 34 Missing ⚠️
internal/inject/wire_gen.go 0.00% 8 Missing ⚠️
internal/command/flags/flags.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
- Coverage   37.98%   36.27%   -1.71%     
==========================================
  Files          91       93       +2     
  Lines        5294     5543     +249     
==========================================
  Hits         2011     2011              
- Misses       3125     3374     +249     
  Partials      158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants