[DRAFT WORK IN PROGRESS] Adding VirtioFS #995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for flintlock-docs canceled.
|
richardcase
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Great work @steve-fraser 🎉 Please don't be put off by the number of comments. Let me know if i can help with anything.
richardcase
reviewed
Dec 31, 2024
richardcase
reviewed
Jan 27, 2025
There was a problem hiding this comment.
I think this looks good to go. Would you be able to do the following:
- confirm what testing you have done locally?
- describe any automated testing that we should add as a follow up to this PR
- Ideally, squash your commits so they tell a story. It doesn't have to be down to 1 but a smaller number is preferable to have a clean commit history.
steve-fraser
changed the base branch from
main
to
dependabot/go_modules/dependencies-5bfb93a580
steve-fraser
changed the base branch from
dependabot/go_modules/dependencies-5bfb93a580
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features adding VirtioFS Support
In a upcoming PR I will be adding
virtiofs_create_test.go
virtiofs_create_delete_test.go
These tests will be testing the create and delete functionality to make sure it's valid on what we expect them to be