-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[work in progress] Node 4 requires gcc-4.8 #1
Conversation
Testing out a change, I was able to get https://github.com/rla/fast-feed/blob/master/.travis.yml to work with a similar effort. Node 4 requires gcc-4.8.
Hi @vielmetti, First, thanks for the PR! Would you like to commit to my branch the GCC changes so I can later merge it in together with my own changes in one PR? |
Yes @lirantal ! I'd like to commit GCC changes to your branch, so you can merge everything together into one PR. I am still working to get something ready to go, it generates a whole stream of errors coming out of |
Sure, so I'll merge it in here only once I'm done merging my upstream PR for v4. Will do it later on tomorrow. |
Sounds good. The cross-reference is rla/fast-feed#26 and this issue in node at nodejs/node#2798 which is extraordinarily useful in understanding how people have done their ports. |
@vielmetti did you get it to actually work and compile node v4 in travis? any insights? |
I ran into the issues you ran into for meanjs - there's some crazy quilt of socket.io depenedencies, and until those get really sorted out it's going to be hard to get a stable build. |
Ok then, thanks for the update! |
https://twitter.com/SocketIO/status/645755967934697472 "Socket.IO 1.3.7 released with Node 4.0.0 support!" |
@vielmetti the build is still failing though even with the 1.3.7 upgrade: https://travis-ci.org/meanjs/mean/jobs/81755320 some package dependency for bufferutil I think |
Yeah, there's some dependency that ends up at ChrisWren/grunt-node-inspector#32 where |
Yep, let's see when this get resolved. |
fixed now in master branch of meanjs and ported here too, thanks @vielmetti ! |
Testing out a change, I was able to get
https://github.com/rla/fast-feed/blob/master/.travis.yml
to work with a similar effort. Node 4 requires gcc-4.8.