Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[work in progress] Node 4 requires gcc-4.8 #1

Closed
wants to merge 5 commits into from
Closed

Conversation

vielmetti
Copy link

Testing out a change, I was able to get

https://github.com/rla/fast-feed/blob/master/.travis.yml

to work with a similar effort. Node 4 requires gcc-4.8.

@lirantal
Copy link
Owner

Hi @vielmetti,

First, thanks for the PR!
I already have a work-in-progress for node v4 at meanjs#906

Would you like to commit to my branch the GCC changes so I can later merge it in together with my own changes in one PR?

@lirantal lirantal self-assigned this Sep 16, 2015
@vielmetti
Copy link
Author

Yes @lirantal ! I'd like to commit GCC changes to your branch, so you can merge everything together into one PR.

I am still working to get something ready to go, it generates a whole stream of errors coming out of nan downstream, but that's useful debug info and I think you could look at https://travis-ci.org/vielmetti/meanjs/jobs/80568987 and conclude that it was useful debug output.

@lirantal
Copy link
Owner

Sure, so I'll merge it in here only once I'm done merging my upstream PR for v4. Will do it later on tomorrow.

@vielmetti
Copy link
Author

Sounds good. The cross-reference is rla/fast-feed#26 and this issue in node at nodejs/node#2798 which is extraordinarily useful in understanding how people have done their ports.

@lirantal
Copy link
Owner

@vielmetti did you get it to actually work and compile node v4 in travis?
our build for meanjs fails here: meanjs#922

any insights?

@vielmetti
Copy link
Author

I ran into the issues you ran into for meanjs - there's some crazy quilt of socket.io depenedencies, and until those get really sorted out it's going to be hard to get a stable build.

@lirantal
Copy link
Owner

Ok then, thanks for the update!

@vielmetti
Copy link
Author

https://twitter.com/SocketIO/status/645755967934697472

"Socket.IO 1.3.7 released with Node 4.0.0 support!"

@lirantal
Copy link
Owner

@vielmetti the build is still failing though even with the 1.3.7 upgrade: https://travis-ci.org/meanjs/mean/jobs/81755320

some package dependency for bufferutil I think

@vielmetti
Copy link
Author

Yeah, there's some dependency that ends up at ChrisWren/grunt-node-inspector#32 where grunt has a plugin that hasn't updated in 5 months that needs some love.

@lirantal
Copy link
Owner

Yep, let's see when this get resolved.

@lirantal
Copy link
Owner

fixed now in master branch of meanjs and ported here too, thanks @vielmetti !

@lirantal lirantal closed this Dec 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants