Adding English navaigation bar. #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi! Can anyone review my code? |
|
非常感谢您的提交。审核代码的过程中有一些问题，只是对导航栏进行了翻译，翻译采用了硬编码，推荐采用语言文件这种方法方便以后支持更多语言。希望能对PR进行一些改进。谢谢你对开源项目的支持。 |
|
Hi!
我很高兴参与到这个项目当中。关于你所提到的问题我也注意到了，我会在有时间的时候进行code修复，并且重新提交PR。
Best regards,
Ryan Wang
…________________________________
发件人: Listen 1 <[email protected]>
发送时间: 2018年12月13日 12:17
收件人: listen1/listen1_chrome_extension
抄送: Xiaochen Wang (Ryan); Author
主题: Re: [listen1/listen1_chrome_extension] Adding English navaigation bar. (#174)
非常感谢您的提交。审核代码的过程中有一些问题，只是对导航栏进行了翻译，翻译采用了硬编码，推荐采用语言文件这种方法方便以后支持更多语言。希望能对PR进行一些改进。谢谢你对开源项目的支持。
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#174 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AWMcSyVO9vuxj2FHJk9RcaxP--xdhEuUks5u4outgaJpZM4XZA2c>.
|
|
期待你的PR ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @listen1! Here I just added an English Navigation Bar. If you want me to translate the whole website, I am willing to do it. Thanks!