Add ugly type assertions for this
#659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of google/closure-compiler#3340 – `this` has an unknown type to closure compiler in static methods. In order to be compatible with the Closure Compiler + JSConformance `BanUnknownThis` check, we must explicitly add type annotations wherever we access `this` in a static method. Yes, this is pretty awful from a legibility perspective. We could improve legibility at the cost of additional size by doing: ```typescript const self = this as typeof LitElement; ``` I went with the zero-size-cost option here.
|
Ugly, but like you said, 0 byte impact. What do we do to ensure we don't regress here? |
|
Also, could we file a bug against tsickle asking them to automatically output the |
justinfagnani
approved these changes
Apr 18, 2019
|
Looks like one was just filed a couple days ago: angular/tsickle#1015 |
|
It should be possible to compile with closure compiler as part of the build process. At the moment the round trip into the internal repo is fast enough though that we should catch and fix regressions quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of google/closure-compiler#3340 –
thishas an unknown type to closure compiler in static methods. In order to be compatible with the Closure Compiler + JSConformanceBanUnknownThischeck, we must explicitly add type annotations wherever we accessthisin a static method.Yes, this is pretty awful from a legibility perspective. We could improve legibility at the cost of additional size by doing:
I went with the zero-size-cost option here.