Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ssr] Fix typo in ssr readme. Fixes #2381 #2406

Merged
merged 3 commits into from
Jan 28, 2022
Merged

[ssr] Fix typo in ssr readme. Fixes #2381 #2406

merged 3 commits into from
Jan 28, 2022

Conversation

kevinpschaaf
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 47da941

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
lit-monorepo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2022 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -3% - +4% (-0.89ms - +1.18ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -1% - +1% (-1.06ms - +0.84ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -3% - +3% (-0.82ms - +1.07ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +2% (-0.28ms - +0.22ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-0.62ms - +0.72ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-1.27ms - +0.43ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -1% - +1% (-6.62ms - +11.26ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -6% - +6% (-5.39ms - +5.89ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +1% (-2.94ms - +2.55ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +4% (-0.69ms - +4.88ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +2% (-4.07ms - +13.31ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -1% - +0% (-10.77ms - +4.07ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +1% (-4.75ms - +13.84ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
76.18ms - 77.65ms-unsure 🔍
-1% - +1%
-1.06ms - +0.84ms		faster ✔
19% - 21%
18.01ms - 20.12ms
tip-of-tree
tip-of-tree		76.43ms - 77.63msunsure 🔍
-1% - +1%
-0.84ms - +1.06ms		-faster ✔
19% - 21%
17.98ms - 19.92ms
previous-release
previous-release		95.22ms - 96.74msslower ❌
23% - 26%
18.01ms - 20.12ms		slower ❌
23% - 26%
17.98ms - 19.92ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
793.45ms - 805.45ms-unsure 🔍
-1% - +1%
-6.62ms - +11.26ms		faster ✔
7% - 8%
56.63ms - 73.71ms
tip-of-tree
tip-of-tree		790.50ms - 803.76msunsure 🔍
-1% - +1%
-11.26ms - +6.62ms		-faster ✔
7% - 9%
58.50ms - 76.48ms
previous-release
previous-release		858.55ms - 870.70msslower ❌
7% - 9%
56.63ms - 73.71ms		slower ❌
7% - 10%
58.50ms - 76.48ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
901.25ms - 910.82ms-unsure 🔍
-1% - +0%
-10.77ms - +4.07ms		faster ✔
4% - 6%
38.04ms - 54.45ms
tip-of-tree
tip-of-tree		903.71ms - 915.06msunsure 🔍
-0% - +1%
-4.07ms - +10.77ms		-faster ✔
4% - 5%
34.15ms - 51.65ms
previous-release
previous-release		945.62ms - 958.95msslower ❌
4% - 6%
38.04ms - 54.45ms		slower ❌
4% - 6%
34.15ms - 51.65ms		-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
30.42ms - 31.86ms-unsure 🔍
-3% - +3%
-0.82ms - +1.07ms		faster ✔
13% - 21%
4.76ms - 8.29ms
tip-of-tree
tip-of-tree		30.40ms - 31.64msunsure 🔍
-3% - +3%
-1.07ms - +0.82ms		-faster ✔
14% - 22%
4.92ms - 8.38ms
previous-release
previous-release		36.05ms - 39.28msslower ❌
15% - 27%
4.76ms - 8.29ms		slower ❌
16% - 27%
4.92ms - 8.38ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
87.61ms - 95.16ms-unsure 🔍
-6% - +6%
-5.39ms - +5.89ms		unsure 🔍
-7% - +4%
-6.73ms - +3.51ms
tip-of-tree
tip-of-tree		86.95ms - 95.33msunsure 🔍
-6% - +6%
-5.89ms - +5.39ms		-unsure 🔍
-8% - +4%
-7.29ms - +3.57ms
previous-release
previous-release		89.54ms - 96.45msunsure 🔍
-4% - +7%
-3.51ms - +6.73ms		unsure 🔍
-4% - +8%
-3.57ms - +7.29ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
26.54ms - 28.08ms-unsure 🔍
-3% - +4%
-0.89ms - +1.18ms		faster ✔
11% - 17%
3.37ms - 5.37ms
tip-of-tree
tip-of-tree		26.48ms - 27.85msunsure 🔍
-4% - +3%
-1.18ms - +0.89ms		-faster ✔
11% - 17%
3.58ms - 5.45ms
previous-release
previous-release		31.04ms - 32.32msslower ❌
12% - 20%
3.37ms - 5.37ms		slower ❌
13% - 20%
3.58ms - 5.45ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
10.94ms - 11.28ms-unsure 🔍
-3% - +2%
-0.28ms - +0.22ms		faster ✔
11% - 14%
1.37ms - 1.73ms
tip-of-tree
tip-of-tree		10.95ms - 11.33msunsure 🔍
-2% - +3%
-0.22ms - +0.28ms		-faster ✔
10% - 14%
1.32ms - 1.72ms
previous-release
previous-release		12.60ms - 12.73msslower ❌
12% - 16%
1.37ms - 1.73ms		slower ❌
12% - 16%
1.32ms - 1.72ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
308.60ms - 312.91ms-unsure 🔍
-1% - +1%
-2.94ms - +2.55ms		faster ✔
29% - 31%
129.79ms - 136.97ms
tip-of-tree
tip-of-tree		309.25ms - 312.65msunsure 🔍
-1% - +1%
-2.55ms - +2.94ms		-faster ✔
29% - 31%
129.85ms - 136.52ms
previous-release
previous-release		441.27ms - 447.01msslower ❌
42% - 44%
129.79ms - 136.97ms		slower ❌
42% - 44%
129.85ms - 136.52ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
54.54ms - 55.47ms-unsure 🔍
-1% - +1%
-0.62ms - +0.72ms		faster ✔
15% - 18%
10.07ms - 11.81ms
tip-of-tree
tip-of-tree		54.48ms - 55.44msunsure 🔍
-1% - +1%
-0.72ms - +0.62ms		-faster ✔
15% - 18%
10.11ms - 11.86ms
previous-release
previous-release		65.21ms - 66.68msslower ❌
18% - 22%
10.07ms - 11.81ms		slower ❌
18% - 22%
10.11ms - 11.86ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
123.30ms - 127.75ms-unsure 🔍
-1% - +4%
-0.69ms - +4.88ms		faster ✔
10% - 14%
14.31ms - 20.08ms
tip-of-tree
tip-of-tree		121.75ms - 125.11msunsure 🔍
-4% - +1%
-4.88ms - +0.69ms		-faster ✔
12% - 15%
16.80ms - 21.78ms
previous-release
previous-release		140.88ms - 144.56msslower ❌
11% - 16%
14.31ms - 20.08ms		slower ❌
13% - 18%
16.80ms - 21.78ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
55.05ms - 56.33ms-unsure 🔍
-2% - +1%
-1.27ms - +0.43ms		faster ✔
0% - 4%
0.09ms - 2.02ms
tip-of-tree
tip-of-tree		55.55ms - 56.66msunsure 🔍
-1% - +2%
-0.43ms - +1.27ms		-unsure 🔍
-3% - +0%
-1.54ms - +0.27ms
previous-release
previous-release		56.03ms - 57.46msslower ❌
0% - 4%
0.09ms - 2.02ms		unsure 🔍
-0% - +3%
-0.27ms - +1.54ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
822.34ms - 834.39ms-unsure 🔍
-0% - +2%
-4.07ms - +13.31ms		unsure 🔍
-1% - +1%
-7.30ms - +9.78ms
tip-of-tree
tip-of-tree		817.48ms - 830.00msunsure 🔍
-2% - +0%
-13.31ms - +4.07ms		-unsure 🔍
-1% - +1%
-12.09ms - +5.32ms
previous-release
previous-release		821.08ms - 833.17msunsure 🔍
-1% - +1%
-9.78ms - +7.30ms		unsure 🔍
-1% - +1%
-5.32ms - +12.09ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
953.83ms - 967.70ms-unsure 🔍
-0% - +1%
-4.75ms - +13.84ms		unsure 🔍
-1% - +2%
-5.29ms - +15.03ms
tip-of-tree
tip-of-tree		950.03ms - 962.41msunsure 🔍
-1% - +0%
-13.84ms - +4.75ms		-unsure 🔍
-1% - +1%
-9.34ms - +9.99ms
previous-release
previous-release		948.47ms - 963.32msunsure 🔍
-2% - +1%
-15.03ms - +5.29ms		unsure 🔍
-1% - +1%
-9.99ms - +9.34ms		-

tachometer-reporter-action v2 for Benchmarks

aomarks
aomarks approved these changes Jan 14, 2022
View reviewed changes
packages/labs/ssr/README.md Outdated
@@ -73,8 +73,8 @@ context.body = Readable.from(ssrResult);

```js
import {myTemplate} from './my-template.js';
import {render, hydrate} from `lit/experimental-hydrate.js`;

import {render} from `lit-html`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not from lit?

@aomarks aomarks changed the title [@lit-labs/ssr] Fix typo in ssr readme. Fixes #2381 [ssr] Fix typo in ssr readme. Fixes #2381 Jan 19, 2022
@aomarks aomarks merged commit 5d77f89 into main Jan 28, 2022
@aomarks aomarks deleted the kevinpschaaf-patch-1 branch January 28, 2022 17:22
@lit-robot lit-robot mentioned this pull request Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aomarks aomarks aomarks approved these changes

@justinfagnani justinfagnani Awaiting requested review from justinfagnani

Assignees

@kevinpschaaf kevinpschaaf

Labels
None yet
Projects
Lit Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinpschaaf @aomarks