Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nonicons, nerdicons: Use license icon for COPYING #355

Merged
merged 4 commits into from
Mar 5, 2024
Merged

nonicons, nerdicons: Use license icon for COPYING #355

merged 4 commits into from
Mar 5, 2024

Conversation

kra-mo
Copy link
Contributor

@kra-mo kra-mo commented Jan 22, 2024

No description provided.

@Guldoman
Copy link
Member

Now that both nonicons and nerdicons have been updated, would you mind rebasing your PR? Thanks.

@kra-mo
Copy link
Contributor Author

kra-mo commented Mar 5, 2024

Alright, rebased

Guldoman
Guldoman reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind bumping the version of the two plugins inside manifest.json?

plugins/nerdicons.lua Outdated Show resolved Hide resolved
@Guldoman Guldoman merged commit 310f6f9 into lite-xl:master Mar 5, 2024
@Guldoman
Copy link
Member

Guldoman commented Mar 5, 2024

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guldoman Guldoman Guldoman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kra-mo @Guldoman