Skip to content

Commit

Permalink
🥳[Feature] Add bech32 to enable ltc1 addresses & false positive rate …
Browse files Browse the repository at this point in the history
…(Bloom Filter) interface (#137)

* Patched in the changes from losh11/bech32

- Pulled in all the changes from loafwallet-core
- From Apr 10, 2022

* Various development refactors

- Updated the tx and addressess lookup URLs
- Updated gitignore
- Removed old binaries from project
- Appended timber debug prefix to “timber:” to easily filter in Logcat
- Bump version code

* Resolved conflicts and merged

Merge branch 'feature/add-bech32' of https://github.com/litecoin-foundation/litewallet-android into feature/add-bech32-14
- Resolved conflicts
- re-added timber prefix

* Add logic to retrieve and display seed phrase

* Added Timber logs

- added localizations
- version and code bump
- Removed the direct wallet info fetch
- This call caused the app the reset the seed.
- instead we are simply pulling the seed from the keystore
- lean to call for seed

* Post testing improvement for FP rates

- The sync period is long in the current configuration
- Spent a few days testing to see if certain false-positives rate for the BloomFilter to adjust the sync time.
- the trade off is: quicker sync = less privacy

Here are the rates that will be offered:
fpr = 0.00005 , sync 77 mins , anonymous
fpr = 0.00002 , sync 42 mins, semi-private
fpr = 0.00001 , sync 19 mins, low-privacy

* Added layout for false positive rate

Added localizations for false positive
waiting to add the func fpupdate(double newfalseupdate) in the loafwallet-core
Adding the needed interface

* Keep build.gradle

- Restore files
- some jni fixes
- Cleanup
- Signed-off-by: Victor Sima <[email protected]>

* All are compiling added the interface in C and Java

- updated to the latest [loafwallet-core](https://github.com/litecoin-foundation/loafwallet-core/tree/master-android)
branch: master-android
commit: 63b18b8

* Updated the gradle to 7.4.2

bumped code and version

* Adjusted analytics for sync

- updated to the latest v1.4.0 loafwallet-core
- updated to the v1.3.0 of loafwallet-core
- Added logging to start collecting the sync times
- updated the loafwallet-core to v1.5.0

* Included a snackbar to notify users on sync.

- Included in the Intro Activity
- Included in the Login (Lock) Activity
- Added translations for the snackbar

---------

Co-authored-by: Victor Sima <[email protected]>
  • Loading branch information
kcw-grunt and vsima committed May 31, 2024
1 parent 532f782 commit 0525357
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,19 @@ public void onCancel() {
}, 500);

setCurrentLtcPrice();

if (BuildConfig.VERSION_NAME == "v2.8.4") {
Snackbar.make(parentLayout,
R.string.release_notes,
Snackbar.LENGTH_INDEFINITE).setAction(R.string.Webview_dismiss, new View.OnClickListener() {
@Override
public void onClick(View view) {

}
})
.setActionTextColor(getResources().getColor(android.R.color.holo_red_light ))
.show();
}
}

private void setCurrentLtcPrice() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ protected void onCreate(Bundle savedInstanceState) {
blogShare = (ImageView) findViewById(R.id.blog_share_button);
versionText.setText(BRConstants.APP_VERSION_NAME_CODE);

infoText.setText(BRConstants.APP_VERSION_NAME_CODE);
versionText.setText(BRConstants.APP_VERSION_NAME_CODE);

instagramShare.setOnClickListener(new View.OnClickListener() {
@Override
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/activity_intro.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/intro_layout"
android:layout_width="match_parent"
android:layout_width="wrap_content"
android:layout_height="match_parent"
android:background="@color/litecoin_litewallet_dark_blue"
android:orientation="vertical">
Expand Down

0 comments on commit 0525357

Please sign in to comment.