[Tech Debt] Remove stale api server code and add switch for dev mode - #98 #103

vsima · 2023-01-15T00:54:11Z

fixes 🦺[Tech Debt] Remove stale api server code and add switch for dev mode #98

- add uk xml file - removed the nl, sv, da files - Escaped apostrphes in UK strings file - Updated language choices

* Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom * subproject commit * version bump * Disabled FB send, Added Get Tasks * Patch to hard code fees - Static fees - Removed the dep - Turn crashlytics back on/off/on Co-authored-by: Victor Sima <[email protected]>

* version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]>

* version code bump * 🚀[ Release v.2.6.0] Merge into Main (#12) * Added український language - add uk xml file - removed the nl, sv, da files - Escaped apostrphes in UK strings file - Updated language choices * 🥳[Feature] Unstoppable ext update (#11) * WIP: DNC Dropped in the UD code prior to testing * Added study link * Fix unstoppable domains dependency * Updated the UD ext text WIP::::Need to refactor once UK and deletion on SV, NL, DA * added UK lang Co-authored-by: Victor Sima <[email protected]> * version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]> Co-authored-by: Victor Sima <[email protected]>

* added bitrefill - added kotlin fix * Added localizations - added logo * Added Bitrefill Link * hides fiat scollview from Bitrefill * Adjusted the padding at the buy tab item view * fixe test in Bitrefill detail * fied logo and layout * bump version and version code

* added new logo - reset the layout * version code

* replaced coin logo * bump versioncode * fixed dep version * added Bitrefill web listener

* Added the equivalenmt events - updated web link * WIP : Should compile * Fixed constants * Udpaded all Analytics constants * Added basic tests - This is WIP - Need to debug the Tests * version bump * fiexd compile bug

* 🚀[ Release v.2.7.0] Merge into Main (#30) * Added український language - add uk xml file - removed the nl, sv, da files - Escaped apostrphes in UK strings file - Updated language choices * 💣🐞[Hotbug fix] sharedprefs fb fix (#19) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom * subproject commit * version bump * Disabled FB send, Added Get Tasks * Patch to hard code fees - Static fees - Removed the dep - Turn crashlytics back on/off/on Co-authored-by: Victor Sima <[email protected]> * 🚀[ Release v.2.6.0] Merge into Develop (#13) * version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]> * 🚀[Release] v2.6.1 (#21) * version code bump * 🚀[ Release v.2.6.0] Merge into Main (#12) * Added український language - add uk xml file - removed the nl, sv, da files - Escaped apostrphes in UK strings file - Updated language choices * 🥳[Feature] Unstoppable ext update (#11) * WIP: DNC Dropped in the UD code prior to testing * Added study link * Fix unstoppable domains dependency * Updated the UD ext text WIP::::Need to refactor once UK and deletion on SV, NL, DA * added UK lang Co-authored-by: Victor Sima <[email protected]> * version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]> Co-authored-by: Victor Sima <[email protected]> * Feature/add bitrefill (#28) * added bitrefill - added kotlin fix * Added localizations - added logo * Added Bitrefill Link * hides fiat scollview from Bitrefill * Adjusted the padding at the buy tab item view * fixe test in Bitrefill detail * fied logo and layout * bump version and version code * Feature/update branding (#29) * added new logo - reset the layout * version code * replaced coin logo * bump versioncode * fixed dep version * added Bitrefill web listener Co-authored-by: Victor Sima <[email protected]> * Create FUNDING.yml For GH Sponsor * 💣🐞[Hotbug fix] sharedprefs fb fix (#19) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom * subproject commit * version bump * Disabled FB send, Added Get Tasks * Patch to hard code fees - Static fees - Removed the dep - Turn crashlytics back on/off/on Co-authored-by: Victor Sima <[email protected]> * Feature/add bitrefill (#28) * added bitrefill - added kotlin fix * Added localizations - added logo * Added Bitrefill Link * hides fiat scollview from Bitrefill * Adjusted the padding at the buy tab item view * fixe test in Bitrefill detail * fied logo and layout * bump version and version code * Feature/update branding (#29) * added new logo - reset the layout * version code * 🚀[ Release v.2.7.0] Merge into Develop (#32) * replaced coin logo * bump versioncode * fixed dep version * added Bitrefill web listener * [Techdebt/] pdate match firebase events 33 (#48) * Added the equivalenmt events - updated web link * WIP : Should compile * Fixed constants * Udpaded all Analytics constants * Added basic tests - This is WIP - Need to debug the Tests * version bump * fiexd compile bug * version bump * renmoved staging * moved backup rates * code bump * Updated test configs * Move api resources to central location - version code bump Co-authored-by: Victor Sima <[email protected]>

* Feature - add donation modal disclaimer - #60 * Add missing strings * Upgraded AS - Reduced donation amount - Renamed id WIP * updated stirings key format - updated the donation address * code bump Co-authored-by: kcw-grunt <[email protected]>

kcw-grunt

We are really close. When I tested it I realized there is no direct way the non-tech users will know which mode they are in.
It needs to be a big flag for them and our support guys to aid in troubleshotting.

This label should disappear when they are in prod mode and when prod server is down, the client should auto-switch to dev and all labels are updated.

Will you add this label in the Nav bar?:

Dev Mode Label

app/build.gradle

kcw-grunt · 2023-01-18T19:06:02Z

app/src/main/java/com/breadwallet/presenter/entities/BRSettingsItem.java

    public String title;
    public String addonText;
+    public Boolean isChecked;
    public View.OnClickListener listener;



This is a really good start. We need to make sure it's visible. Will you add this:

Status label

Switch background color

Settings Dev Mode: On Settings Dev Mode: Off

How does this look?

vsima · 2023-01-21T01:25:54Z

Dev mode copy added to the main screen:

kcw-grunt · 2023-01-21T10:10:54Z

cc: @vsima the servers are not quite ready so I approved but not merging until after the
#82 is all ready and we get a prod release out.

* Feature - Show Litecoin Card as Webview - remove partner api library - create card frament webview and add to bottom nav - fixes #58 * bump version code * Fix UI crash * bump version code Co-authored-by: kcw-grunt <[email protected]>

…#98

- move dev & prod urls into constants

josikie

Great! @kcw-grunt @vsima
Thanks!

I have some questions:

what is this syntax called: v -> {....} (AdvancedActivity.java, lines 141)?
what is an inflater?
what is android:foreground for, and why does it value selectableItemBackground?

kcw-grunt · 2024-03-29T09:42:25Z

will not do

kcw-grunt and others added 25 commits May 24, 2022 17:51

Added український language

c491d9c

- add uk xml file - removed the nl, sv, da files - Escaped apostrphes in UK strings file - Updated language choices

🚀[ Release v.2.6.0] Merge into Develop (#13)

3fff6a1

* version bump * Hotfix/crashes v2.6.0 (#17) * Added notes * Bugfix - add missing pendingIntent flag for android 13 * Use firebase bom Co-authored-by: kcw-grunt <[email protected]> Co-authored-by: Victor Sima <[email protected]>

Feature/update branding (#29)

c553cf7

* added new logo - reset the layout * version code

Create ISSUE_TEMPLATE

56e9056

Delete ISSUE_TEMPLATE

6d109b5

Create test.md

5d74332

Create bug_report.md

047b2f3

Delete bug_report.md

d4ee871

Create feature.md

d714b51

Create feature_request.md

e53b7c9

Create request.md

87dfc61

Create spike.md

6d4e3f1

Create techdebt.md

82041dd

Delete feature.md

cb1ecb2

Delete feature_request.md

15176f1

Delete request.md

0f29150

Delete spike.md

00182f6

Delete tech_debt.md

438dd84

Delete test.md

04c0034

🚀[ Release v.2.7.0] Merge into Develop (#32)

8cb4971

* replaced coin logo * bump versioncode * fixed dep version * added Bitrefill web listener

[Techdebt/] pdate match firebase events 33 (#48)

80e20a0

* Added the equivalenmt events - updated web link * WIP : Should compile * Fixed constants * Udpaded all Analytics constants * Added basic tests - This is WIP - Need to debug the Tests * version bump * fiexd compile bug

Fix - revert FragmentBuy webview test (#72)

451fff8

vsima requested a review from kcw-grunt January 15, 2023 00:54

vsima self-assigned this Jan 15, 2023

vsima force-pushed the feature/api-server-98 branch from 58d2c50 to 332315e Compare January 15, 2023 00:58

kcw-grunt and others added 2 commits January 15, 2023 11:53

Commented out the partial work

e130db7

kcw-grunt and others added 2 commits January 15, 2023 12:18

Add .circleci/config.yml (#74)

ebf1e6e

vsima marked this pull request as draft January 17, 2023 16:33

vsima force-pushed the feature/api-server-98 branch 3 times, most recently from e06ef90 to e013c19 Compare January 17, 2023 20:55

vsima marked this pull request as ready for review January 17, 2023 20:55

vsima force-pushed the feature/api-server-98 branch from e013c19 to 49bea1f Compare January 17, 2023 21:05

kcw-grunt suggested changes Jan 18, 2023

View reviewed changes

vsima force-pushed the feature/api-server-98 branch 2 times, most recently from 684bcb6 to 35f8e90 Compare January 21, 2023 01:04

kcw-grunt self-requested a review January 21, 2023 10:07

kcw-grunt approved these changes Jan 21, 2023

View reviewed changes

kcw-grunt added the DO NOT MERGE label Jan 21, 2023

kcw-grunt added this to the v2.9.0 milestone Jan 21, 2023

kcw-grunt removed the DO NOT MERGE label Jan 22, 2023

vsima and others added 4 commits January 24, 2023 23:40

Feature - Show Litecoin Card as Webview (#82)

9cb9653

* Feature - Show Litecoin Card as Webview - remove partner api library - create card frament webview and add to bottom nav - fixes #58 * bump version code * Fix UI crash * bump version code Co-authored-by: kcw-grunt <[email protected]>

[Tech Debt] Remove stale api server code and add switch for dev mode - …

0187160

…#98

- update advanced settings ui

bb6d58a

- move dev & prod urls into constants

- add dev mode copy to toolbar

5db18c0

vsima force-pushed the feature/api-server-98 branch from ef26a46 to 5db18c0 Compare January 27, 2023 16:46

kcw-grunt force-pushed the develop branch from 9cb9653 to dc3f4ef Compare January 30, 2023 08:26

kcw-grunt force-pushed the develop branch from 1b2d260 to d40495b Compare April 8, 2023 15:46

kcw-grunt requested a review from josikie May 26, 2023 19:38

josikie approved these changes May 27, 2023

View reviewed changes

kcw-grunt closed this Mar 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tech Debt] Remove stale api server code and add switch for dev mode - #98 #103

[Tech Debt] Remove stale api server code and add switch for dev mode - #98 #103

vsima commented Jan 15, 2023

kcw-grunt left a comment

kcw-grunt Jan 18, 2023

vsima Jan 21, 2023

kcw-grunt Jan 21, 2023

vsima commented Jan 21, 2023

kcw-grunt commented Jan 21, 2023

josikie left a comment

kcw-grunt commented Mar 29, 2024

[Tech Debt] Remove stale api server code and add switch for dev mode - #98 #103

[Tech Debt] Remove stale api server code and add switch for dev mode - #98 #103

Conversation

vsima commented Jan 15, 2023

kcw-grunt left a comment

Choose a reason for hiding this comment

kcw-grunt Jan 18, 2023

Choose a reason for hiding this comment

vsima Jan 21, 2023

Choose a reason for hiding this comment

kcw-grunt Jan 21, 2023

Choose a reason for hiding this comment

vsima commented Jan 21, 2023

kcw-grunt commented Jan 21, 2023

josikie left a comment

Choose a reason for hiding this comment

kcw-grunt commented Mar 29, 2024