feat: Implement Firebase Cloud Messaging & In-app Messaging #296

andhikayuana · 2024-12-14T00:23:28Z

Overview

Simple implementation for Firebase Cloud Messaging and Firebase In-app Messaging

Issue

https://github.com/litecoin-foundation/litewallet-engineering/issues/3

Self Test

will share on slack

kcw-grunt · 2024-12-14T09:55:56Z

👀

andhikayuana · 2024-12-14T12:07:13Z

app/src/main/java/com/breadwallet/BreadApp.java

+//                .addOnSuccessListener(new OnSuccessListener<String>() {
+//                    @Override
+//                    public void onSuccess(String s) {
+//                        Timber.d("timber: fcm getToken= %s", s);


to log fcm token, in case we need to test fcm with specific device

andhikayuana · 2024-12-14T12:08:06Z

app/src/main/java/com/breadwallet/BreadApp.java

        if (BuildConfig.DEBUG) Timber.plant(new Timber.DebugTree());
        DISPLAY_HEIGHT_PX = Resources.getSystem().getDisplayMetrics().heightPixels;

        String afID = Utils.fetchPartnerKey(this, PartnerNames.AFDEVID);
        AppsFlyerLib.getInstance().init(afID, null, this);
        AppsFlyerLib.getInstance().start(this);
    }
+


again, this is I am using the shortcut/menu that mentioned before

andhikayuana · 2024-12-14T12:08:29Z

app/src/main/java/com/breadwallet/presenter/activities/BreadActivity.java

+    private final ActivityResultLauncher<String> requestNotificationPermissionLauncher =
+            registerForActivityResult(new ActivityResultContracts.RequestPermission(), isGranted -> {
+                if (isGranted) {
+                    Toast.makeText(app, R.string.permission_notification_granted, Toast.LENGTH_SHORT).show();


if granted just show toast here

andhikayuana · 2024-12-14T12:09:26Z

app/src/main/java/com/breadwallet/presenter/activities/BreadActivity.java

        showInAppReviewDialogIfNeeded();
    }

+    private void setupNotificationPermission() {
+        //https://developer.android.com/develop/ui/views/notifications/notification-permission


notification runtime permission available from API level 33 and higher

andhikayuana · 2024-12-14T12:09:53Z

app/src/main/java/com/breadwallet/presenter/activities/BreadActivity.java

+            if (ActivityCompat.shouldShowRequestPermissionRationale(this, Manifest.permission.POST_NOTIFICATIONS)) {
+                new AlertDialog.Builder(this)
+                        .setTitle(R.string.permission_info)
+                        .setMessage(R.string.please_grant_notification_permission)


just show dialog if shouldShowRequestPermissionRationale return true

andhikayuana · 2024-12-14T12:10:39Z

app/src/main/java/com/breadwallet/tools/util/BRConstants.java

@@ -141,6 +141,7 @@ private BRConstants() {
    public static final String _20240101_US = "user_signup";
    public static final String _20241006_DRR = "did_request_rating";
    public static final String _20241006_UCR = "user_completed_rating";
+    public static final String _HOME_OPEN = "home_open";


this is event to trigger display in-app messaging, will share the video on slack

https://firebase.google.com/docs/in-app-messaging/modify-message-behavior?platform=android#trigger_in-app_messages_programmatically_2

andhikayuana · 2024-12-14T12:12:20Z

app/src/main/java/com/litewallet/notification/NotificationHandler.kt

+        }
+
+        val channelId = remoteMessage.notification?.channelId ?: NOTIFICATION_CHANNEL_ID_GENERAL
+        val title = remoteMessage.data["title"] ?: return false


regarding notification vs data payload details here https://firebase.google.com/docs/cloud-messaging/concept-options#notifications_and_data_messages

andhikayuana · 2024-12-14T12:12:58Z

app/src/main/res/values/strings.xml

@@ -776,4 +776,13 @@
  <string name="Announce.no_thanks">No, thanks!</string>
    <string name="Fees.Service">Service</string>
    <string name="ConfirmationAllFees.Label">Fees:</string>
+
+  <string name="notification_channel_name_general" translatable="false">General</string>


currently I just create this new copy, do we have to translate into all of languages?

I'm not sure. What do you think @kcw-grunt ?

for channel name maybe no need to translate, but like please_grant_notification_permission I think we need to translate

Good question. Im wrapping my head around leveraging the Google Translate in the FCM dashboard @andhikayuana

andhikayuana · 2024-12-14T12:13:23Z

app/src/test/java/com/litewallet/notification/NotificationHandlerTest.kt

+        mockkStatic(NotificationManagerCompat::class)
+        every { NotificationManagerCompat.from(context).notify(any()) } just Runs
+
+        //todo: revisit, test still fail because specific platform API e.g. android.app.Notification$Builder


need to revisit later, since error with specific API platform here

josikie · 2024-12-16T09:22:03Z

app/src/main/java/com/litewallet/notification/NotificationHandler.kt

+            .setContentIntent(pendingIntent)
+            .setAutoCancel(true)
+
+        NotificationManagerCompat.from(context)


What does NotificationManagerCompat do?

to post/cancel android notification on the status bar android
more https://developer.android.com/develop/ui/views/notifications/build-notification#notify

josikie · 2024-12-16T09:23:14Z

app/src/main/java/com/litewallet/util/PermissionUtil.kt

+        ) == PackageManager.PERMISSION_GRANTED
+    }
+
+    @JvmStatic


Will this ask user the permission for notifications when user open the app for the first time?

this is for general purpose runtime permission, you can find the implementation at BreadActivity https://github.com/litecoin-foundation/litewallet-android/pull/296/files#diff-63c75cf9310b8ced1dd7141be03a32c7b4071d12c12e1876074beaf0035eeb0dR152

@josikie this allows us to reach the users that are using the app. So, we dont need push notification authorization
@andhikayuana please correct me if I got this wrong...;)

Ok, noted! @kcw-grunt

josikie

LGTM. Thank you! @andhikayuana

kcw-grunt

LGTM
But, everyone in the Litewallet team needs to test this feature and we need to ilicit feedback as we do iOS version

kcw-grunt · 2024-12-17T18:45:17Z

app/src/main/java/com/litewallet/util/PermissionUtil.kt

+        ) == PackageManager.PERMISSION_GRANTED
+    }
+
+    @JvmStatic


@josikie this allows us to reach the users that are using the app. So, we dont need push notification authorization
@andhikayuana please correct me if I got this wrong...;)

kcw-grunt · 2024-12-17T18:46:46Z

app/src/main/java/com/litewallet/util/PermissionUtil.kt

+object PermissionUtil {
+
+    @JvmStatic
+    fun hasPermissions(context: Context, permissions: Array<String>): Boolean {


@andhikayuana is this for inapp only permission? Or is this for auth for when the app is closed. Or is it both?

kcw-grunt · 2024-12-17T18:47:27Z

app/src/main/java/com/breadwallet/presenter/activities/BreadActivity.java

+    private final ActivityResultLauncher<String> requestNotificationPermissionLauncher =
+            registerForActivityResult(new ActivityResultContracts.RequestPermission(), isGranted -> {
+                if (isGranted) {
+                    Toast.makeText(app, R.string.permission_notification_granted, Toast.LENGTH_SHORT).show();


kcw-grunt · 2024-12-17T18:49:19Z

app/src/main/res/values/strings.xml

@@ -776,4 +776,13 @@
  <string name="Announce.no_thanks">No, thanks!</string>
    <string name="Fees.Service">Service</string>
    <string name="ConfirmationAllFees.Label">Fees:</string>
+
+  <string name="notification_channel_name_general" translatable="false">General</string>


Good question. Im wrapping my head around leveraging the Google Translate in the FCM dashboard @andhikayuana

* feat: add notification channel * feat: add PermissionUtil * feat: request notification permission for API 33 or above * feat: implement firebase in-app messaging * feat: implement simple cloud messaging * feat: add NotificationHandlerTest

andhikayuana added 5 commits December 14, 2024 04:51

feat: add notification channel

7eea5f4

feat: add PermissionUtil

737c92d

feat: request notification permission for API 33 or above

ac8273e

feat: implement firebase in-app messaging

9c1e3c3

feat: implement simple cloud messaging

d396e38

feat: add NotificationHandlerTest

e1a6c4e

andhikayuana commented Dec 14, 2024

View reviewed changes

andhikayuana requested review from kcw-grunt and josikie December 14, 2024 12:14

andhikayuana marked this pull request as ready for review December 14, 2024 12:14

andhikayuana self-assigned this Dec 14, 2024

josikie reviewed Dec 16, 2024

View reviewed changes

josikie approved these changes Dec 16, 2024

View reviewed changes

kcw-grunt approved these changes Dec 17, 2024

View reviewed changes

kcw-grunt added the 🥳 feature New feature or enhancement request label Dec 19, 2024

kcw-grunt added this to the v2.13.X milestone Dec 19, 2024

kcw-grunt merged commit 39d6fdd into develop Dec 19, 2024
0 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement Firebase Cloud Messaging & In-app Messaging #296

feat: Implement Firebase Cloud Messaging & In-app Messaging #296

andhikayuana commented Dec 14, 2024 •

edited

Loading

kcw-grunt commented Dec 14, 2024

andhikayuana Dec 14, 2024

andhikayuana Dec 14, 2024

andhikayuana Dec 14, 2024 •

edited

Loading

kcw-grunt Dec 17, 2024

andhikayuana Dec 14, 2024

andhikayuana Dec 14, 2024 •

edited

Loading

andhikayuana Dec 14, 2024

andhikayuana Dec 14, 2024

andhikayuana Dec 14, 2024

andhikayuana Dec 14, 2024

josikie Dec 16, 2024

andhikayuana Dec 17, 2024

kcw-grunt Dec 17, 2024

andhikayuana Dec 14, 2024

josikie Dec 16, 2024 •

edited

Loading

andhikayuana Dec 17, 2024

josikie Dec 16, 2024

andhikayuana Dec 17, 2024

kcw-grunt Dec 17, 2024

josikie Dec 18, 2024

josikie left a comment

kcw-grunt left a comment

kcw-grunt Dec 17, 2024

kcw-grunt Dec 17, 2024

kcw-grunt Dec 17, 2024

kcw-grunt Dec 17, 2024

feat: Implement Firebase Cloud Messaging & In-app Messaging #296

feat: Implement Firebase Cloud Messaging & In-app Messaging #296

Conversation

andhikayuana commented Dec 14, 2024 • edited Loading

Overview

Issue

Self Test

kcw-grunt commented Dec 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andhikayuana Dec 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andhikayuana Dec 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josikie Dec 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josikie left a comment

Choose a reason for hiding this comment

kcw-grunt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andhikayuana commented Dec 14, 2024 •

edited

Loading

andhikayuana Dec 14, 2024 •

edited

Loading

andhikayuana Dec 14, 2024 •

edited

Loading

josikie Dec 16, 2024 •

edited

Loading