Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦺[Tech debt] Add develop & GS keys file 43 #45

Merged
merged 11 commits into from
May 8, 2021
Merged

🦺[Tech debt] Add develop & GS keys file 43 #45

merged 11 commits into from
May 8, 2021

Conversation

kcw-grunt
Copy link
Contributor

@kcw-grunt kcw-grunt commented May 4, 2021 •
edited
Loading

Overview

This work allows other iOS developers to compile the project without the private prod files.

kcw-grunt added 3 commits May 4, 2021 13:51
@kcw-grunt
Refactored file partner data
ef2f291 
- Added file structure
@kcw-grunt
Made calls to retrieve the keys
cfb23e8 
- Checked UD Key usage
- Checked GS Key Usage
- Reset gitignore filitering
@kcw-grunt
Delete GoogleService-Info.plist
4f683ca
@kcw-grunt kcw-grunt linked an issue May 4, 2021 that may be closed by this pull request
🦺[Tech Debt] Add dummy file for new Litewallet teammates to compile #43
Closed
@kcw-grunt kcw-grunt marked this pull request as ready for review May 4, 2021 13:31
kcw-grunt
kcw-grunt commented May 4, 2021
View reviewed changes
@kcw-grunt kcw-grunt force-pushed the techdebt/add-develop-keys-files-43 branch from ffcfd01 to f2826b0 Compare May 4, 2021 13:51
@kcw-grunt kcw-grunt force-pushed the techdebt/add-develop-keys-files-43 branch from 8f86112 to d785b9b Compare May 4, 2021 14:14
mosadialiou
mosadialiou suggested changes May 4, 2021
View reviewed changes
@kcw-grunt
Copy link
Contributor Author

kcw-grunt commented May 7, 2021 •
edited
Loading

cc: @JasperHeist

@kcw-grunt kcw-grunt force-pushed the techdebt/add-develop-keys-files-43 branch from 62c21f5 to 803374b Compare May 7, 2021 14:40
@kcw-grunt kcw-grunt requested a review from mosadialiou May 7, 2021 16:44
@kcw-grunt kcw-grunt changed the title Techdebt/add develop keys files 43 🦺[Tech debt] Add develop & GS keys file 43 May 7, 2021
mosadialiou
mosadialiou suggested changes May 7, 2021
View reviewed changes
loafwallet/PartnerData.swift
/// Returns Partner Key
/// - Parameter name: Enum for the different partners
/// - Returns: Key string
static func partnerKeyPath(name: PartnerName) -> String {
Copy link
Contributor

@mosadialiou mosadialiou May 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kcw-grunt this function is difficult to read. it should be refactored but for now we can live with it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mosadialiou
this is a built-in feature provided by Xcode and wherever I can I'm updating methods accordingly:

Screen Shot 2021-05-08 at 12 42 11 PM

@kcw-grunt kcw-grunt requested a review from mosadialiou May 8, 2021 11:43
mosadialiou
mosadialiou approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@mosadialiou mosadialiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcw-grunt kcw-grunt merged commit c10dc3c into develop May 8, 2021
@JCHeist
Copy link
Contributor

JCHeist commented May 9, 2021

@kcw-grunt After following the readme I got past all my pod issues but I am having issues with signing and accessing the LitewalletPartnerAPI.

Signing
I am using my personal development team. Should I be using a different one, or use other settings in the loafWallet "Signing & Capabilities?"

  1. "Personal development teams, including "Jasper Heist", do not support the Push Notifications capability."
  2. "No profiles for 'com.litecoin.loafwallet' were found
    Xcode couldn't find any iOS App Development provisioning profiles matching 'com.litecoin.loafwallet'."
    image

LiteWalletPartnerAPI

  1. "https://github.com/litecoin-foundation/LitewalletPartnerAPI.git: The remote repository could not be accessed. Make sure a valid repository exists at the specified location and that the correct credentials have been supplied."

image

@kcw-grunt
Copy link
Contributor Author

@kcw-grunt After following the readme I got past all my pod issues but I am having issues with signing and accessing the LitewalletPartnerAPI.

Signing
I am using my personal development team. Should I be using a different one, or use other settings in the loafWallet "Signing & Capabilities?"

  1. "Personal development teams, including "Jasper Heist", do not support the Push Notifications capability."
  2. "No profiles for 'com.litecoin.loafwallet' were found
    Xcode couldn't find any iOS App Development provisioning profiles matching 'com.litecoin.loafwallet'."
    image

LiteWalletPartnerAPI

  1. "https://github.com/litecoin-foundation/LitewalletPartnerAPI.git: The remote repository could not be accessed. Make sure a valid repository exists at the specified location and that the correct credentials have been supplied."

image

Thanks @JasperHeist this is the proper path and I need to submit another PR for you. The one I just submitted should be a starting point. But this is good progress. The fault is mine. Thanks for your patience.

@JCHeist
Copy link
Contributor

JCHeist commented May 12, 2021

@kcw-grunt Cool, no problem. Ill await that, meanwhile I took a look at that other PR. For whatever help I can be while I don't have it running.

@kcw-grunt kcw-grunt deleted the techdebt/add-develop-keys-files-43 branch May 15, 2021 14:18
@JCHeist
Copy link
Contributor

JCHeist commented May 16, 2021

@kcw-grunt After following the readme I got past all my pod issues but I am having issues with signing and accessing the LitewalletPartnerAPI.
Signing
I am using my personal development team. Should I be using a different one, or use other settings in the loafWallet "Signing & Capabilities?"

  1. "Personal development teams, including "Jasper Heist", do not support the Push Notifications capability."
  2. "No profiles for 'com.litecoin.loafwallet' were found
    Xcode couldn't find any iOS App Development provisioning profiles matching 'com.litecoin.loafwallet'."
    image

LiteWalletPartnerAPI

  1. "https://github.com/litecoin-foundation/LitewalletPartnerAPI.git: The remote repository could not be accessed. Make sure a valid repository exists at the specified location and that the correct credentials have been supplied."

image

Thanks @JasperHeist this is the proper path and I need to submit another PR for you. The one I just submitted should be a starting point. But this is good progress. The fault is mine. Thanks for your patience.

@kcw-grunt After following the readme I got past all my pod issues but I am having issues with signing and accessing the LitewalletPartnerAPI.

Signing
I am using my personal development team. Should I be using a different one, or use other settings in the loafWallet "Signing & Capabilities?"

  1. "Personal development teams, including "Jasper Heist", do not support the Push Notifications capability."
  2. "No profiles for 'com.litecoin.loafwallet' were found
    Xcode couldn't find any iOS App Development provisioning profiles matching 'com.litecoin.loafwallet'."
    image

LiteWalletPartnerAPI

  1. "https://github.com/litecoin-foundation/LitewalletPartnerAPI.git: The remote repository could not be accessed. Make sure a valid repository exists at the specified location and that the correct credentials have been supplied."

image

So the LitewalletPartnerAPI is fixed now since I was added to that Github organization, but I still am having the push notification error. Do I needed to be added to an Apple Development team or should I just turn off push notifications in Capabilities? @kcw-grunt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosadialiou mosadialiou mosadialiou approved these changes

@RyanPetter RyanPetter Awaiting requested review from RyanPetter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🦺[Tech Debt] Add dummy file for new Litewallet teammates to compile
3 participants
@kcw-grunt @JCHeist @mosadialiou