Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥳[Feature] Redesign unlock view #50

Merged
merged 6 commits into from
May 17, 2021

Conversation

kcw-grunt
Copy link
Contributor

Issue

Closes #7

Why?

The current price (in the header view) was confusing many users and the lock screen needed a refresh.

Screenshots

Before ENG-USD FR-GBP ENG-EUR
LegacyLockScreen Eng-USD-NewLockScreen Fra-GBP-NewLockScreen Eng-EUR-NewLockScreen

@JCHeist
Copy link
Contributor

JCHeist commented May 16, 2021

On the topic of the lock screen, I have not found a way to set up biometrics to login, Is that set up and Im missing it or is it something that we should create an issue for? @kcw-grunt
Hey @JasperHeist it's in the settings > Security > TouchID/Face ID

Copy link
Contributor

@JCHeist JCHeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still have somewhere we can show the price after logging in, even if it's just in the menu or something. If you think not, we can push this down to a future redesign. @kcw-grunt

I do agree that it was confusing having current holdings and price right there though.

Copy link
Contributor

@mosadialiou mosadialiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcw-grunt
Copy link
Contributor Author

I think we should still have somewhere we can show the price after logging in, even if it's just in the menu or something. If you think not, we can push this down to a future redesign. @kcw-grunt

I do agree that it was confusing having current holdings and price right there though.

Agreed. This was just a stop the bleeding fix. Too many people think when they download Litewallet, the balance was on the right and "Where's my money?" " How do I get the $200?" ...I wish I was kidding.

@kcw-grunt kcw-grunt merged commit 92986e5 into develop May 17, 2021
@kcw-grunt kcw-grunt deleted the feature/redesign-unlock-view-7 branch April 17, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🥳 [Feature] Redesign of Login View
3 participants