Feature/add turkish language support 51 #53

JCHeist · 2021-05-29T03:26:58Z

No description provided.

…issues. Most of the comments are in turkish now though, not ideal?

JCHeist · 2021-05-29T03:33:23Z

Hey @kcw-grunt , I still need to convert some of these comments back to english. Other than that we should be good to go. Do we test these or have UI Tests?

~~-Also, side note: Somehow I can't build again. Did anything change with the UnstoppableDomainsResolution pod? That's the one that is seeming to give me issues.~~

JCHeist · 2021-05-30T16:49:55Z

@kcw-grunt Still working on getting these comments back to english, but I did test that the turkish localized strings appear when you change the app language on a device. Can't speak to how good the translations are though ha

Because: - needed englsih comments after i put the whole file in google translaete. wrote a script for this. should have done that sooner.

JCHeist · 2021-05-31T02:38:16Z

@kcw-grunt Comments are done. Looks like it's linked up properly but I may have missed something. I added tr to BartyCrouch but not sure I used it.

Also, I ended up writing a python script because this is a pain haha. Should be able to modify the script a bit and use google tranlate to do a future translation in a few minutes instead of a few hours lol.

Because: - I think these files need to be source controlled. Especially the .lock and .resolved files. As the workspace get's bigger and we begin to use frameworks, having a source controlled xcode workspace will be necessarry in my opinion.

JCHeist · 2021-05-31T17:48:06Z

Added these files in this ^ commit because I'd like to get your thoughts on if they should be included. And if not, why. @kcw-grunt

kcw-grunt

Some of these are going to needed to be reverted as the main changes should be the .strings (TR) file and the added new localization.

loafwallet/src/Strings/tr.lproj/Localizable.strings

kcw-grunt · 2021-06-05T15:19:09Z

loafwallet/src/Strings/tr.lproj/Localizable.strings


-/* Fee Selector title */
-"FeeSelector.title" = "Processing Speed";
+/* Ücret Seçici başlığı */


@JasperHeist Oh I see its confusing but the process is to leave the Comments in english (revert line 238) for example. Line 239 is correct. Meaning only the content on the right side of the label name.

kcw-grunt · 2021-06-05T15:19:52Z

loafwallet/src/Strings/tr.lproj/Localizable.strings


-/* High fees error message */
-"Import.Error.highFees" = "Transaction fees would cost more than the funds available on this private key.";
+/* Yüksek ücret hata mesajı */


@JasperHeist same here and the rest of the file as commented above

kcw-grunt · 2021-06-05T15:23:56Z

Podfile.lock

@@ -0,0 +1,129 @@
+PODS:
+  - BigInt (5.2.0)


Pods should be part of the .gitignore

kcw-grunt · 2021-06-05T15:26:23Z

TodayExtension/tr.lproj/MainInterface.strings


 /* Class = "UILabel"; text = "send"; ObjectID = "QMM-JV-cTG"; */
-"QMM-JV-cTG.text" = "**send**";
+"QMM-JV-cTG.text" = "send";


@JasperHeist All changes to this file should be reverted as we haven't supported localization for the Today Ext. (someday)

kcw-grunt · 2021-06-05T15:27:27Z

loafwallet.xcodeproj/project.pbxproj

@@ -4603,6 +4599,7 @@
 			children = (
 				75A2A79D1DA5934300A983D8 /* Base */,
 				249F976D236F86240045087A /* id */,
+				37198C1426549D6000F6F36C /* tr */,


looks good 😀

kcw-grunt · 2021-06-05T15:29:56Z

loafwallet.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>


@JasperHeist This should be reverted and check the .gitignore. Let's talk on making sure your env matches mine.

kcw-grunt · 2021-06-05T15:30:14Z

loafwallet.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>


@JasperHeist This should be reverted and check the .gitignore. Let's talk on making sure your env matches mine.

mosadialiou

all IDE... files should be deleted since they are related to your Xcode environment.

mosadialiou · 2021-06-01T15:10:46Z

loafwallet/tr.lproj/LaunchScreen.strings

@@ -0,0 +1 @@
+


@JasperHeist empty file. must be deleted

mosadialiou · 2021-06-05T15:51:17Z

loafwallet.xcodeproj/xcuserdata/jcheist.xcuserdatad/xcschemes/xcschememanagement.plist

@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>


@JasperHeist to be deleted. This file is related to your Xcode environment

mosadialiou · 2021-06-05T15:52:40Z

loafwallet.xcodeproj/project.xcworkspace/contents.xcworkspacedata

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>


@JasperHeist it looks like a file to delete. @kcw-grunt thoughts?

mosadialiou · 2021-06-05T15:53:35Z

loafwallet.xcworkspace/contents.xcworkspacedata

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>


@JasperHeist Looks like a file to remove from git. @kcw-grunt thoughts?

This reverts commit 6db0c60.

Because: - A few strings files should not have been added. Deleted the unused ones xcode added

…odayExtension Because: - we do not currently support TodayExtension and the main.storyboard files were deleted since they were empty

Because: - FIle was not saved during previous commit

- Unignored Podfile.lock - Added it back into source control - Reformatted comments - Included xcshareddata to source control

Because: - before the gitignore is updated, this file needs to be removed so my old xcuserdata is not always in there

Because: - to ignore all xcuserdata again

…ll be ignored in the future

Because: - removed to fix extra file in source

Because: - For documentation

…ed xcuserdata Because: - sometimes it is called [UserName].xcuserdata

Because: - was red in the workspace

…60-jasper-diff

…age-support-51 # Conflicts: # loafwallet.xcodeproj/project.pbxproj Merged in dev env and develop changes

kcw-grunt

@JasperHeist Just let me know when you want me to review since we are now in sync.

JCHeist · 2021-07-08T15:09:51Z

sweet @kcw-grunt I will. Sorry Ive been a bit MIA so far this week.

…Add-Turkish-Language-support-51 # Conflicts: # .gitignore # Podfile.lock

kcw-grunt

Just the storyboard issue. Other wise it looks good. Just let me me know.

kcw-grunt · 2021-07-09T21:58:51Z

loafwallet/src/Strings/tr.lproj/Localizable.strings

@@ -0,0 +1,1382 @@
+/* About screen website label */


@JasperHeist how much fun did you have filling this out? Great? or Fantastic?

loafwallet/CHANGELOG.md

TodayExtension/Base.lproj/MainInterface.storyboard

This reverts commit 97b68a2.

kcw-grunt · 2021-07-10T14:57:32Z

👀..need to pull it in a few hours.

Changes updated

kcw-grunt

LGTM

JCHeist added 8 commits May 18, 2021 20:59

removed plists

5afdfd2

added turkish locale to Xcode project

a6f8390

beginning of adding turkish locale

bd0e021

about 1/3 the way done with running strings through google translate

8dc786d

Some more strings work

69e8587

Going to fix one issue causing strings to be ouside quotes

403120c

words all translated and errored formatting strings fixed formatting …

9cd43f3

…issues. Most of the comments are in turkish now though, not ideal?

added turkish to supported languages in BartyCrouch enum

9d0aec8

brought back a few english comments, need to find another way to do this

6ac4a19

JCHeist marked this pull request as ready for review May 30, 2021 16:47

JCHeist requested a review from kcw-grunt May 30, 2021 16:49

Swapped out comments in turkish for english ones

1cafdb1

Because: - needed englsih comments after i put the whole file in google translaete. wrote a script for this. should have done that sooner.

kcw-grunt suggested changes Jun 5, 2021

View reviewed changes

mosadialiou suggested changes Jun 5, 2021

View reviewed changes

loafwallet/tr.lproj/LaunchScreen.strings Outdated

@@ -0,0 +1 @@

Copy link

Contributor

mosadialiou Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JasperHeist empty file. must be deleted

mosadialiou suggested changes Jun 5, 2021

View reviewed changes

JCHeist added 4 commits June 6, 2021 12:23

Revert "Added files that currently don't exist in workspace"

6e27999

This reverts commit 6db0c60.

Addressing PR

30f6b7c

Because: - A few strings files should not have been added. Deleted the unused ones xcode added

Removed localizations for Main.storyboard and localizations for the T…

fc271b3

…odayExtension Because: - we do not currently support TodayExtension and the main.storyboard files were deleted since they were empty

Today Extension.

97b68a2

Because: - FIle was not saved during previous commit

JCHeist requested review from kcw-grunt and mosadialiou June 8, 2021 01:03

kcw-grunt and others added 4 commits June 10, 2021 10:07

Clean up .gitignore

b021865

- Unignored Podfile.lock - Added it back into source control - Reformatted comments - Included xcshareddata to source control

Updated from pod install

760dd82

What's different on Jasper's branch after a clean and build

378c6ca

Re-add xcuserdata in gitignore

bde6475

JCHeist added 11 commits June 11, 2021 07:29

deleted file in scuserdata

13bc225

Because: - before the gitignore is updated, this file needs to be removed so my old xcuserdata is not always in there

readded gitignore changes

daf6e85

Because: - to ignore all xcuserdata again

removed xcuserdata from workspace that should be blown out now and wi…

c4ab61c

…ll be ignored in the future

.gitignore readded

b1ea2fd

Because: - removed to fix extra file in source

Updated comment in .gitignore

61f398b

Because: - For documentation

added extra clause to gitignore for when xcuserdata folder is not nam…

1dcfdf8

…ed xcuserdata Because: - sometimes it is called [UserName].xcuserdata

Corrected path to libbz2 module

5203709

Because: - was red in the workspace

Merge branch 'develop' into techdebt/60-jasper-diff

b765790

Merge branch 'develop' into techdebt/project-for-dev-60-DevelopSync

b543e0f

Merge branch 'techdebt/project-for-dev-60-DevelopSync' into techdebt/…

93f80b1

…60-jasper-diff

Merge branch 'techdebt/60-jasper-diff' into feature/Add-Turkish-Langu…

86fc286

…age-support-51 # Conflicts: # loafwallet.xcodeproj/project.pbxproj Merged in dev env and develop changes

kcw-grunt reviewed Jul 6, 2021

View reviewed changes

JCHeist added 5 commits July 8, 2021 18:36

Merge commit '113e9fc734eb3e0ec6432ffaa4a09195223daaaf' into feature/…

2a86d12

…Add-Turkish-Language-support-51 # Conflicts: # .gitignore # Podfile.lock

removed zombie objects from scheme

6ced5bb

readed reference to main plist files

953371e

removed launch screen.storyboard strings for indonesian language

1a06585

removed tribal changeling changes

947fdf6

JCHeist requested review from kcw-grunt and removed request for mosadialiou July 9, 2021 02:15

kcw-grunt previously requested changes Jul 9, 2021

View reviewed changes

JCHeist and others added 3 commits July 9, 2021 20:21

Revert "Today Extension."

3c57b1a

This reverts commit 97b68a2.

reverted changes to LItewallet storyboard

b890b32

changed storyboard part 2

f3bf349

JCHeist requested a review from kcw-grunt July 10, 2021 00:31

kcw-grunt approved these changes Jul 10, 2021

View reviewed changes

JCHeist merged commit d9d6f04 into develop Jul 11, 2021

kcw-grunt deleted the feature/Add-Turkish-Language-support-51 branch July 11, 2021 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/add turkish language support 51 #53

Feature/add turkish language support 51 #53

JCHeist commented May 29, 2021

JCHeist commented May 29, 2021 •

edited

Loading

JCHeist commented May 30, 2021

JCHeist commented May 31, 2021

JCHeist commented May 31, 2021

kcw-grunt left a comment

kcw-grunt Jun 5, 2021

kcw-grunt Jun 5, 2021

kcw-grunt Jun 5, 2021

kcw-grunt Jun 5, 2021

kcw-grunt Jun 5, 2021

kcw-grunt Jun 5, 2021

kcw-grunt Jun 5, 2021

mosadialiou left a comment

mosadialiou Jun 1, 2021

mosadialiou Jun 5, 2021

mosadialiou Jun 5, 2021

mosadialiou Jun 5, 2021

kcw-grunt left a comment

JCHeist commented Jul 8, 2021

kcw-grunt left a comment

kcw-grunt Jul 9, 2021

kcw-grunt commented Jul 10, 2021

kcw-grunt left a comment

Feature/add turkish language support 51 #53

Feature/add turkish language support 51 #53

Conversation

JCHeist commented May 29, 2021

JCHeist commented May 29, 2021 • edited Loading

JCHeist commented May 30, 2021

JCHeist commented May 31, 2021

JCHeist commented May 31, 2021

kcw-grunt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mosadialiou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kcw-grunt left a comment

Choose a reason for hiding this comment

JCHeist commented Jul 8, 2021

kcw-grunt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kcw-grunt commented Jul 10, 2021

kcw-grunt left a comment

Choose a reason for hiding this comment

JCHeist commented May 29, 2021 •

edited

Loading