Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flushing OS cache to medium #582

Merged
merged 1 commit into from
May 8, 2017
Merged

Added flushing OS cache to medium #582

merged 1 commit into from
May 8, 2017

Conversation

mkosieradzki
Copy link
Contributor

This solves #574 . However only the for the portable version, because Flush(true) API has been added in .NET Framework 4 (and works properly since .NET Framework 4.5). So it will not work in .NET Framework 3.5.

@mbdavid mbdavid merged commit fda371a into litedb-org:master May 8, 2017
@lidanger
Copy link

lidanger commented Jun 13, 2017

How about Flush(true) in .NET Framework 4? @mkosieradzki

It seems the bug was fixed until version 4.5 according to the following page:
https://connect.microsoft.com/VisualStudio/feedback/details/634385/filestream-flush-flushtodisk-true-call-does-not-flush-the-buffers-to-disk

@lidanger
Copy link

lidanger commented Jun 13, 2017

Can you compile the code to other version of the .NET Framework and add the library to the Nuget? @mbdavid

@mbdavid
Copy link
Collaborator

mbdavid commented Jun 13, 2017

@lidanger, yes, both in .net35 and netstandard. But its implemented only for netstandard (so, will not work in .net 4)

#if !NET35
            _journal.Flush(true);
#endif

github-actions bot pushed a commit to Reddevildragg-UPM-Forks/LiteDB that referenced this pull request Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants