Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: examples omitted in schema produced by dto #3510

Merged
merged 1 commit into from
May 18, 2024

Conversation

peterschutt
Copy link
Contributor

Fixes issue where a BodyKwarg instance provided as metadata to a data type annotation was ignored for OpenAPI schema generation when the data type is managed by a DTO.

Closes #3505

Description

Closes

Fixes issue where a `BodyKwarg` instance provided as metadata to a data type annotation was ignored for OpenAPI schema generation when the data type is managed by a DTO.

Closes #3505
@peterschutt peterschutt requested review from a team as code owners May 17, 2024 22:17
@github-actions github-actions bot added area/dto This PR involves changes to the DTOs size: small type/bug pr/internal labels May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (5afa40f) to head (f990203).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3510   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         328      328           
  Lines       14875    14876    +1     
  Branches     2365     2365           
=======================================
+ Hits        14623    14624    +1     
  Misses        115      115           
  Partials      137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3510

Copy link
Contributor

@Alc-Alc Alc-Alc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by "Cody and Coffee partying" gang

@peterschutt peterschutt merged commit b49de66 into main May 18, 2024
28 checks passed
@peterschutt peterschutt deleted the 3505-dto-schema-retain-openapi-meta branch May 18, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dto This PR involves changes to the DTOs pr/internal size: small type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples not shown when using DTO
2 participants