Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated example for flash messages #3530

Merged
merged 2 commits into from
May 27, 2024
Merged

docs: updated example for flash messages #3530

merged 2 commits into from
May 27, 2024

Conversation

cofin
Copy link
Member

@cofin cofin commented May 27, 2024

Description

The flash messages plugin requires a valid session configuration. This PR adds a basic configuration to the examples. Previously, an exception would be raised when executing the examples.

Closes

@cofin cofin requested review from a team as code owners May 27, 2024 15:04
@github-actions github-actions bot added area/docs This PR involves changes to the documentation size: small pr/internal labels May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (057f813) to head (af40e98).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3530      +/-   ##
==========================================
- Coverage   98.28%   98.28%   -0.01%     
==========================================
  Files         328      328              
  Lines       14881    14845      -36     
  Branches     2362     2357       -5     
==========================================
- Hits        14626    14590      -36     
  Misses        116      116              
  Partials      139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@Alc-Alc Alc-Alc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: not chore(docs) 😛

@cofin cofin changed the title chore(docs): updated example for flash messages docs: updated example for flash messages May 27, 2024
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3530

@cofin cofin merged commit 0884764 into main May 27, 2024
27 checks passed
@cofin cofin deleted the flash-session branch May 27, 2024 15:20
Murtagy pushed a commit to Murtagy/litestar that referenced this pull request May 30, 2024
* chore(docs): updated example for flash messages

* chore: remove redundant store config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This PR involves changes to the documentation pr/internal size: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants