fix(testing): .websocket_connect does not respect base_url
#3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provinzkraut
force-pushed
the
test-client-request
branch
from
2546b8c to
292658a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3567 +/- ##
==========================================
- Coverage 98.28% 98.27% -0.01%
==========================================
Files 328 328
Lines 14859 14819 -40
Branches 2362 2361 -1
==========================================
- Hits 14604 14564 -40
Misses 116 116
Partials 139 139 ☔ View full report in Codecov by Sentry. |
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3567 |
provinzkraut
added a commit
that referenced
this pull request
Jun 21, 2024
* Fix WS client base url (cherry picked from commit 95951db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that caused the
.websocket_connectmethods onTestClientandAsyncTestClientto not respect thebase_urlset in the client's constructor, and instead would use the staticws://testerverURL as a base.Also removes most of the test client code as it was unneeded and in the way of this fix :)
Explanation for the last part: All the extra code we had was just proxying method calls to the
httpx.Client/httpx.AsyncClient, while altering the base URL. Since we already set the base URL on the httpx Client's superclass instance, which in turn does this merging internally, this step isn't needed at all.