Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): add param logging_module to LoggingConfig #3578

Conversation

jderrien
Copy link
Contributor

Description

logging_module provides a way to switch easily from logging to picologging.

Closes

Closes #3536

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (12193b4) to head (396f620).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3578      +/-   ##
==========================================
- Coverage   98.28%   98.27%   -0.02%     
==========================================
  Files         328      328              
  Lines       14850    14856       +6     
  Branches     2362     2363       +1     
==========================================
+ Hits        14595    14599       +4     
  Misses        116      116              
- Partials      139      141       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jderrien jderrien force-pushed the logging-config-add-logging-module-param branch from 4d4450a to 396f620 Compare June 17, 2024 14:37
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3578

@provinzkraut provinzkraut merged commit a1f5b3b into litestar-org:main Jun 17, 2024
25 checks passed
@jderrien jderrien deleted the logging-config-add-logging-module-param branch June 17, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: add an option logging_module to LoggingConfig
3 participants