Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signature): Fix #3593: Ensure signature model internal function signatures don't clash with model signature #3605

Merged
merged 3 commits into from
Jun 30, 2024

Conversation

provinzkraut
Copy link
Member

Fix #3593 by ensuring that the functions used by the signature model itself do not interfere with the signature model created.

@provinzkraut provinzkraut requested review from a team as code owners June 30, 2024 18:35
@github-actions github-actions bot added area/dependencies This PR involves changes to the dependencies area/kwargs area/private-api This PR involves changes to the privatized API area/signature size: small type/bug pr/internal labels Jun 30, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (de8f4a7) to head (62348bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3605   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         328      328           
  Lines       14870    14870           
  Branches     2366     2366           
=======================================
  Hits        14611    14611           
  Misses        117      117           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut enabled auto-merge (squash) June 30, 2024 18:50
@provinzkraut provinzkraut merged commit 3a6a293 into main Jun 30, 2024
24 checks passed
@provinzkraut provinzkraut deleted the fix-3593 branch June 30, 2024 18:58
Copy link

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3605

Alc-Alc pushed a commit that referenced this pull request Jul 26, 2024
…ignatures don't clash with model signature (#3605)

* Ensure signature model internal function signatures don't clash with model signature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies This PR involves changes to the dependencies area/kwargs area/private-api This PR involves changes to the privatized API area/signature pr/internal size: small type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: multiple values for keyword arguments
2 participants