Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OpenTelemetry doesn't capture exceptions in the outermost application layer #3689

Merged
merged 7 commits into from
Aug 24, 2024

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Aug 23, 2024

Extend the work done in #3665. For description / discussion, check over there.

Fixes #3663.

bella and others added 3 commits August 21, 2024 21:17
@provinzkraut provinzkraut requested review from a team as code owners August 23, 2024 19:31
@github-actions github-actions bot added area/docs This PR involves changes to the documentation area/plugins This PR involves changes to the plugins size: small pr/internal labels Aug 23, 2024
@provinzkraut provinzkraut changed the title Fix otel pr refactor: otel pr #3665 [WIP] Aug 23, 2024
@provinzkraut provinzkraut marked this pull request as draft August 23, 2024 19:34
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (b7ab355) to head (e9b51f7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3689   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         328      329    +1     
  Lines       14890    14936   +46     
  Branches     2369     2375    +6     
=======================================
+ Hits        14633    14679   +46     
  Misses        116      116           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the area/plugins This PR involves changes to the plugins label Aug 23, 2024
@provinzkraut provinzkraut marked this pull request as ready for review August 23, 2024 20:36
@provinzkraut provinzkraut changed the title refactor: otel pr #3665 [WIP] fix: OpenTelemetry doesn't capture exceptions in the outermost application layer Aug 23, 2024
@provinzkraut provinzkraut enabled auto-merge (squash) August 23, 2024 20:38
Copy link

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3689

@provinzkraut provinzkraut merged commit d1ef753 into main Aug 24, 2024
28 checks passed
@provinzkraut provinzkraut deleted the fix-otel-pr branch August 24, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This PR involves changes to the documentation pr/internal size: small type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: OpenTelemetry Middleware Doesn't Capture Exceptions Raised Before Route Handler
2 participants