feat(middleware): Warn about greedy exclude patterns #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/docs
provinzkraut
force-pushed
the
warn-middleware-exclude-all
branch
from
b81d113 to
5d8dbbc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3700 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 329 329
Lines 14965 14973 +8
Branches 2382 2383 +1
=======================================
+ Hits 14708 14716 +8
Misses 116 116
Partials 141 141 ☔ View full report in Codecov by Sentry. |
|
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3700 |
euri10
reviewed
Aug 25, 2024
euri10
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a warning when a middlewares
excludepattern greedily matches all paths.Also document this footgun more prominently.