-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Metadata handling #3721
Conversation
@peterschutt If you have the time, a review or even a quick look from you would be greatly appreciated :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3721 +/- ##
==========================================
+ Coverage 98.29% 98.34% +0.05%
==========================================
Files 330 331 +1
Lines 15139 15268 +129
Branches 2405 2443 +38
==========================================
+ Hits 14881 15016 +135
+ Misses 117 112 -5
+ Partials 141 140 -1 ☔ View full report in Codecov by Sentry. |
0097075
to
0a20946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have anything to add other than nice work. It looks good to me.
0a20946
to
c5601e6
Compare
c5601e6
to
34658d7
Compare
Quality Gate passedIssues Measures |
Make the metadata extraction from type annotations more robust.
Supersedes #3308.
Fixes #3710.
Fixes #3656.
Fixes #3722.