Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix DTO Data section with a new example #3813

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 16, 2024

Link: https://docs.litestar.dev/latest/usage/dto/1-abstract-dto.html#dto-data

There were several issues:

  1. Model was renamed to User from Person
  2. There was no 500 error no more
  3. Explanation about default field was missing
  4. CreatePerson should be better named UserCreate "noun-verb" to better group models
  5. Code highlight was marking wrong lines
Снимок экрана 2024-10-16 в 11 20 04

@sobolevn sobolevn requested review from a team as code owners October 16, 2024 08:20
@github-actions github-actions bot added area/docs This PR involves changes to the documentation size: small type/docs pr/external Triage Required 🏥 This requires triage labels Oct 16, 2024
@sobolevn
Copy link
Member Author

@Alc-Alc thank you for quick reviews! 👍

@provinzkraut provinzkraut enabled auto-merge (squash) October 17, 2024 07:22
@provinzkraut provinzkraut merged commit 45d5ec1 into main Oct 17, 2024
24 checks passed
@provinzkraut provinzkraut deleted the dto-data-rewrite branch October 17, 2024 07:28
Copy link

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This PR involves changes to the documentation pr/external pr/internal size: small Triage Required 🏥 This requires triage type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants