Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(OpenAPI): Query-only properties included in path, cookie and header parameter schema and response headers (#3908) #3909

Merged
merged 4 commits into from
Dec 22, 2024
Merged

fix(OpenAPI): Query-only properties included in path, cookie and header parameter schema and response headers (#3908) #3909

merged 4 commits into from
Dec 22, 2024

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Dec 22, 2024 •
edited
Loading

Remove the inclusion of the query-only properties allowEmptyValue and allowReserved in path, cookie, header parameter and response header schemas.

Fixes #3908

@provinzkraut provinzkraut requested review from a team as code owners December 22, 2024 17:56
@codecov Codecov
Copy link

codecov bot commented Dec 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (6c2bb39) to head (b476d42).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3909   +/-   ##
=======================================
  Coverage   98.35%   98.36%           
=======================================
  Files         346      346           
  Lines       15660    15686   +26     
  Branches     1730     1736    +6     
=======================================
+ Hits        15403    15429   +26     
  Misses        122      122           
  Partials      135      135

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut changed the title fix(OpenAPI): Query-only properties included in path, cookie and header parameter schema (#3908) fix(OpenAPI): Query-only properties included in path, cookie and header parameter schema and response headers (#3908) Dec 22, 2024
cofin
cofin approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@provinzkraut provinzkraut enabled auto-merge (squash) December 22, 2024 18:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 New Major Issues (required ≤ 2)
4 New Code Smells (required ≤ 3)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@provinzkraut provinzkraut merged commit 11df596 into main Dec 22, 2024
26 of 27 checks passed
@provinzkraut provinzkraut deleted the fix-3908 branch December 22, 2024 18:46
@github-actions github-actions bot mentioned this pull request Dec 22, 2024
Closed
4 tasks
@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofin cofin cofin approved these changes

Assignees
No one assigned
Labels
area/datastructures pr/internal size: small type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: OpenAPI - query parameter only properties used in other parameters
2 participants
@provinzkraut @cofin