Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compression middleware): Fix resource handling #3927

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

provinzkraut
Copy link
Member

Fix a few cases where we didn't close resources in the right order, leading to either "unclosed resource" or "I/O on closed file" warnings

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.34%. Comparing base (f5ba3a7) to head (59a5674).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
litestar/middleware/compression/middleware.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3927      +/-   ##
==========================================
- Coverage   98.36%   98.34%   -0.02%     
==========================================
  Files         347      347              
  Lines       15722    15727       +5     
  Branches     1737     1738       +1     
==========================================
+ Hits        15465    15467       +2     
- Misses        122      124       +2     
- Partials      135      136       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 5, 2025

Copy link

github-actions bot commented Jan 5, 2025

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3927

@provinzkraut provinzkraut merged commit 2fb6f6b into main Jan 5, 2025
26 of 27 checks passed
@provinzkraut provinzkraut deleted the fix-compression-resource-handling branch January 5, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants