Add better Tuple benchmarks #729
Conversation
|
@liufengyun note that I modified I removed the old tuple benchmarks. This set will give us more meaningful results. |
|
@nicolasstucki Can we just keep the old tests and add new ones? Removing lines involves migrating data, which causes additional maintenance efforts. |
|
Can't we just ignore old data and not show it in the graphs? |
|
@nicolasstucki We could have stale data in the database, just that it is not ideal. We can merge this anyway, and deal with the obsolete data later. |
tests/tuple22-tails.scala
Outdated
| @@ -0,0 +1,4 @@ | |||
| class Foo { | |||
| val tup: (Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int, Int) = ??? | |||
| tup.tail.tail.tail.tail.tail | |||
There was a problem hiding this comment.
Do we want to call head to mirror apply?
There was a problem hiding this comment.
Head will become an instance of apply(0) therefore the test would be redundant.
There was a problem hiding this comment.
BTW, do we want to go beyond 22, to test the feature more stressfully :)
There was a problem hiding this comment.
Will do. Also should put some small tuples.
|
It would be good to merge and run it for a few commits in the past to be able to use it in scala/scala3#6539 and compare the results. |
|
Deployed and scheduled regressional tests for recent 13 merges. |
No description provided.