Fix a bug in window validation (facebookincubator#103)

liujiayi771 · Feb 27, 2023 · 3d4b205 · 3d4b205
1 parent b144073
commit 3d4b205
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/velox/substrait/SubstraitToVeloxPlanValidator.cpp b/velox/substrait/SubstraitToVeloxPlanValidator.cpp
@@ -245,9 +245,11 @@ bool SubstraitToVeloxPlanValidator::validate(
               windowFunction.window_type());
       }
 
-      validateBoundType(windowFunction.upper_bound());
-      validateBoundType(windowFunction.lower_bound());
-
+      bool boundTypeSupported = validateBoundType(windowFunction.upper_bound()) &&
+       validateBoundType(windowFunction.lower_bound());
+      if (!boundTypeSupported) {
+        return false;
+      }
     } catch (const VeloxException& err) {
       std::cout << "Validation failed for window function due to: "
                 << err.message() << std::endl;