Accessibility / markup improvements #48
Open
+11,407
−10,153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: John Rayes <[email protected]>
Co-authored-by: John Rayes <[email protected]>
Co-authored-by: Diego Andrés <[email protected]> Signed-off-by: John Rayes <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
- wrap code in preformatted html tags - do the same in the sceditor - bonus: fix php tag processing in the sceditor - php 8.3 changes highlight_string(), so update our integrations - do not add php start and end php tags to the final output of the php bbcode - add buttons for selecting and expanding code blocks with js; don't output them from php - remove smfSelectText( ) as it is unused now Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: Diego Andrés <[email protected]>
Signed-off-by: John Rayes <[email protected]>
Signed off by: Edward Koltun <[email protected]>
live627
force-pushed
the
theme
branch
2 times, most recently
from
d8e63a2 to
65df69e
Compare
live627
force-pushed
the
theme
branch
4 times, most recently
from
df4b491 to
b28e58a
Compare
live627
force-pushed
the
theme
branch
4 times, most recently
from
0603a45 to
78a6a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, first time contributor here.
I made a start on some accessibility & markup improvements with viewing topics. The main changes are the use of the article element with proper labeling and better usage of headings. Tested with JAWS and NVDA using Firefox and Chrome on Windows.
There's much more that can be done, but I wanted to get some feedback and thoughts on direction before I go any further.