Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax app directory permissions in Docker #1193

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

jonatanklosko
Copy link
Member

Closes #1192.

@jonatanklosko jonatanklosko force-pushed the jk-docker-permissions branch from 500d601 to a6b990a Compare May 17, 2022 20:40
@josevalim
Copy link
Contributor

@jonatanklosko I was also thinking we could not attempt to write the cookie file if we do not have write permission. Any preferences?

@jonatanklosko
Copy link
Member Author

@josevalim but in this case we want to write the random cookie, no? I think running docker with or without --user shouldn't make a difference in this regard.

@josevalim
Copy link
Contributor

@josevalim but in this case we want to write the random cookie, no?

We only write the random cookie in case you want to reuse it across restarts or something of sorts. I don't think that would be the case with Docker and you can always pass RELEASE_COOKIE yourself.

@jonatanklosko
Copy link
Member Author

@josevalim ah that change was probably for consistency with the app release, where this was relevant. But either way, I don't think --user should make a difference.

Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your call :)

@jonatanklosko jonatanklosko merged commit ec6de91 into main May 17, 2022
@jonatanklosko jonatanklosko deleted the jk-docker-permissions branch May 17, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission denied on docker startup, when using --user flag
2 participants