Support Kino.Input.textarea option to switch to monospace font
#1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As inputs will be ingested and operated on by code, showing input as monospaced prevents confusion by presented the text the same way it would be displayed when assigned to a string in code.
|
|
|
Yeah, I definitely think we want to make it opt-in as textarea are not always code specific. |
|
Thought that might be the case, sounds good to me! Combined with livebook-dev/kino#220 this allows for the
|
zolrath
changed the title
Kino.Input.textarea option to switch to monospace font
zolrath
changed the title
Kino.Input.textarea option to switch to monospace fontKino.Input.textarea option to switch to monospace font
Co-authored-by: Jonatan Kłosko <[email protected]>
✅ Signed! |
Uffizzi Preview Environment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As inputs will be ingested and operated on by code, showing input as monospaced prevents confusion by presented the text the same way it would be displayed when assigned to a string in code.
Reference
Before
After
Alternatives
I have another branch that modifies Kino to allow a
monospaceoption, allowing monospaced to be turned on/off on a textarea by textarea basis, but thought I would submit the simplest version first.