-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move app settings to a modal and add explanations #1914
Conversation
jonatanklosko
commented
May 20, 2023
ed12966
to
6abd007
Compare
Uffizzi Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I pushed a bunch of nitpicks
So let's go with these headers: "Application", "Latest deploy" (or "Current deploy") and "App sessions". :) |
@josevalim we say "app" everywhere, so for consistency it's better than "application", no? |
Deploy is a verb, not sure if that mattes though :p |
Alright so: "App", "Latest deployment" (or "Current deployment") and "Running sessions"? I don't want to say "App sessions" because App is implied? |
Sounds good! |
Co-authored-by: José Valim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the comments have been addressed. :)
Co-authored-by: José Valim <[email protected]>