Changes for Elixir 1.15 #1918
Merged
Changes for Elixir 1.15 #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
jonatanklosko
commented
May 23, 2023
Comment on lines
+604
to
+620
| try do | ||
| quoted = Code.string_to_quoted!(code, file: env.file) | ||
|
|
||
| try do | ||
| {value, binding, env} = | ||
| Code.eval_quoted_with_env(quoted, binding, env, prune_binding: true) | ||
|
|
||
| {:ok, value, binding, env} | ||
| catch | ||
| kind, error -> | ||
| stacktrace = prune_stacktrace(__STACKTRACE__) | ||
| {:error, kind, error, stacktrace} | ||
| end | ||
| catch | ||
| kind, error -> | ||
| {:error, kind, error, []} | ||
| end |
There was a problem hiding this comment.
This is so that for parsing errors we always return an empty stacktrace.
jonatanklosko
commented
May 23, 2023
Comment on lines
+348
to
+356
| defp ensure_order(map) do | ||
| map | ||
| |> Enum.sort() | ||
| |> Enum.map(fn | ||
| {key, %{} = value} -> {key, ensure_order(value)} | ||
| pair -> pair | ||
| end) | ||
| |> Jason.OrderedObject.new() | ||
| end |
There was a problem hiding this comment.
Serialized maps used to have sorted keys, now we sort explicitly, so it's easier to test the exported source.
josevalim
reviewed
May 29, 2023
| defp io_proxy?(pid) do | ||
| try do | ||
| info = Process.info(pid, [:dictionary]) | ||
| info[:dictionary][:"$initial_call"] == {Livebook.Runtime.Evaluator.IOProxy, :init, 1} |
There was a problem hiding this comment.
I wonder if we can use the Registry instead of this check... 🤔
There was a problem hiding this comment.
Will do in a separate PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1713.
Requires elixir-lang/elixir#12585.