Erlang error improvements #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
filmor
commented
Jun 6, 2023
filmor
commented
- Convert Erlang tokenizer/parser errors to SyntaxError, format exceptions
- Raise TokenMissingError for incomplete input
- Use the same snippet code as Elixir does
|
Uffizzi Preview |
filmor
force-pushed
the
erlang-errors
branch
2 times, most recently
from
117f092 to
dab72da
Compare
josevalim
reviewed
Jun 6, 2023
josevalim
reviewed
Jun 6, 2023
lib/livebook/runtime/evaluator.ex
Outdated
Comment on lines
771
to
781
| SyntaxError.exception( | ||
| file: env.file, | ||
| line: :erl_anno.line(location), | ||
| column: | ||
| case :erl_anno.column(location) do | ||
| :undefined -> 1 | ||
| val -> val | ||
| end, | ||
| description: description, | ||
| snippet: make_snippet(code, location) | ||
| ) |
There was a problem hiding this comment.
I think we should encapsulate this in a function? Something like syntax_error(SyntaxError, description, code, location, env)? Then we can reuse it from different places. :)
There was a problem hiding this comment.
Check the latest commit, like that?
|
Looks great! Ideally we would show them as Erlang errors (as in the Erlang shell) but I think this is a great first step. :) |
josevalim
approved these changes
Jun 6, 2023
|
@filmor awesome, can you also add an evaluator test for those errors? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.