-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on-hover details for types #1974
Add on-hover details for types #1974
Conversation
- show type definition - show full type signature in first line, including module - include docs link
9eaf315
to
5c1c328
Compare
c3a7afd
to
3df610c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! Just a couple nitpicks :)
Co-authored-by: Jonatan Kłosko <[email protected]>
Uffizzi Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐈
@jonatanklosko Just now noticed that the additions do not apply for the details of autocomplete suggestions. Should I take another look at that? |
@awerment yes, please! It should be a matter of adjusting this: livebook/lib/livebook/intellisense.ex Lines 255 to 267 in 7691324
|
Hello! 👋
Been bugged by the fact that type specs are not displayed in the on-hover windows and decided to try and change that.
This PR adds more details:
GenServer.on_start()
instead of juston_start
Examples
Elixir before
Elixir after
Erlang before
Erlang after