Refactor configuration module and support updating the service configuration #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostbyte73
approved these changes
Nov 30, 2023
davidzhao
reviewed
Nov 30, 2023
| ServiceName string `yaml:"-"` | ||
| NodeID string // Do not provide, will be overwritten | ||
| ServiceName string `yaml:"service_name"` | ||
| NodeID string `yaml:"node_id"` // Do not provide, will be overwritten |
There was a problem hiding this comment.
since we'll override it, should it be yaml:"-" ? same for ServiceName
There was a problem hiding this comment.
This needs to be serialized when passing the config to the handler process
davidzhao
approved these changes
Dec 1, 2023
biglittlebigben
added a commit
that referenced
this pull request
Dec 21, 2023
## Changelog ## Fixed - Refactor configuration module and support updating the service configuration (#174) - Refactor health handler (#176) - Count URL requests in the prometheus requests gauge (#179) - Stop the gstreamer pipeline cleanly when deleting an ingress (#181) - Drain output channel on EOS (#183)
Merged
biglittlebigben
added a commit
that referenced
this pull request
Dec 21, 2023
## Changelog ## Fixed - Refactor configuration module and support updating the service configuration (#174) - Refactor health handler (#176) - Count URL requests in the prometheus requests gauge (#179) - Stop the gstreamer pipeline cleanly when deleting an ingress (#181) - Drain output channel on EOS (#183)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.