Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

Add hover style over device option menu entries #64

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Jun 16, 2022

Just a small thing that we did in our fork – brings simple visual feedback which input device option is currently hovered over.

@CLAassistant
Copy link

CLAassistant commented Jun 16, 2022

CLA assistant check
All committers have signed the CLA.

@lukasIO
Copy link
Contributor

lukasIO commented Jun 27, 2022

Thanks @Philzen !
We recently added the changesets CLI to the repo in order to track changes across the different packages.
It would be great, if you could run yarn changeset and follow the prompts. Your change would be a patch bump for @livekit/react-components.

@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2022

🦋 Changeset detected

Latest commit: b5fe49b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@livekit/react-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Philzen
Copy link
Contributor Author

Philzen commented Jul 2, 2022

Done... pfewww that took almost longer than the actual fix 😆

Interesting tool though. Wonder if this could be automated in the github CI via comments or labels or what-have-you?

@lukasIO
Copy link
Contributor

lukasIO commented Jul 4, 2022

thank you!
yeah, for smaller fixes it feels a bit cumbersome, but it's a great way to keep track of changes across packages.

@lukasIO lukasIO merged commit a30b2dd into livekit:master Jul 4, 2022
@github-actions github-actions bot mentioned this pull request Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants