Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify number matching rules. Make '+' optional. #737

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Jun 12, 2024

Quite a few support questions from customers regarding SIP are made because of a tiny mistake in the number format in their Trunks. Twilio requires leading +, while Telnyx omits it by default.

This change makes + always optional for inbound calls. We will still accept the call if the Trunk has + set, but INVITE omits it (and vise versa).

In addition, make effort to fix outbound calls (CreateSIPParticipant requests) too by checking the base domain in SIP URI. It's not perfect and won't work if provider changes the domain. But it will help avoid most common problems.

@dennwc dennwc self-assigned this Jun 12, 2024
Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: 31369d9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@dennwc dennwc force-pushed the sip-simplify-num-match branch from b9a523c to 31369d9 Compare June 13, 2024 10:25
@dennwc dennwc merged commit 0411da6 into main Jun 13, 2024
3 checks passed
@dennwc dennwc deleted the sip-simplify-num-match branch June 13, 2024 10:26
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants