Simplify number matching rules. Make '+' optional. #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few support questions from customers regarding SIP are made because of a tiny mistake in the number format in their Trunks. Twilio requires leading
+
, while Telnyx omits it by default.This change makes
+
always optional for inbound calls. We will still accept the call if the Trunk has+
set, butINVITE
omits it (and vise versa).In addition, make effort to fix outbound calls (
CreateSIPParticipant
requests) too by checking the base domain in SIP URI. It's not perfect and won't work if provider changes the domain. But it will help avoid most common problems.