Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filename prefix to ImagesInfo #751

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Conversation

frostbyte73
Copy link
Member

If filename templating is used, it's impossible to know the image locations without inspecting/listing your bucket

@frostbyte73 frostbyte73 requested a review from a team July 4, 2024 00:44
Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: f710fdd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@frostbyte73 frostbyte73 merged commit b272353 into main Jul 5, 2024
3 checks passed
@frostbyte73 frostbyte73 deleted the images-filename-prefix branch July 5, 2024 15:50
@github-actions github-actions bot mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants