Added ROOM_CLOSED as a DisconnectReason #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all independent participants leave the room, the room would close and disconnect all dependent participants. They should receive the correct reason. Currently we are sending `UNKNOWN_REASON`
🦋 Changeset detectedLatest commit: fabb6bd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
lukasIO
approved these changes
Aug 1, 2024
theomonnom
approved these changes
Aug 1, 2024
paulwe
approved these changes
Aug 2, 2024
Merged
davidzhao
added a commit
that referenced
this pull request
Aug 2, 2024
* Added ROOM_CLOSED as a DisconnectReason When all independent participants leave the room, the room would close and disconnect all dependent participants. They should receive the correct reason. Currently we are sending `UNKNOWN_REASON` * generated protobuf * changeset --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all independent participants leave the room, the room would close and disconnect all dependent participants. They should receive the correct reason. Currently we are sending
UNKNOWN_REASON