Some metrics protocol changes #806
Conversation
- Add an envelope time stamp. That should be timestamp when the packet is actually sent. - Remove `start_timestamp`/`end_timestamp` from `TimeseriesMetric` as it is not clear how it will be used. Can add later if needed.
🦋 Changeset detectedLatest commit: dc586e3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
boks1971
requested review from
bcherry,
paulwe,
davidzhao,
keepingitneil,
lukasIO and
theomonnom
protobufs/livekit_metrics.proto
Outdated
| @@ -42,22 +43,20 @@ message TimeSeriesMetric { | |||
| uint32 label = 1; | |||
| uint32 participant_identity = 2; | |||
| uint32 track_sid = 3; | |||
| int64 start_timestamp = 4; // samples | |||
| int64 end_timestamp = 5; | |||
| // list of samples between start_timestamp and end_timestamp | |||
There was a problem hiding this comment.
oops, cleaning up.
|
oh by the way, could you also add a changeset? |
|
I still do not understand how to generate this changeset thing properly. Will read up more. Hopefully, this is good enough for this - 726d0b4 |
Hmm, I made this |
|
okay, trying again - dc586e3. Made it a patch. Also, included all packages although |
lg! |
* Some metrics protocol changes - Add an envelope time stamp. That should be timestamp when the packet is actually sent. - Remove `start_timestamp`/`end_timestamp` from `TimeseriesMetric` as it is not clear how it will be used. Can add later if needed. * generated protobuf * change comment * generated protobuf * comments * generated protobuf * clean up * generated protobuf * comment to mention absolute time * generated protobuf * adding server normalized timestamps * generated protobuf * comment * generated protobuf * comments * generated protobuf * Changeset * remove incorrect changeset * try again --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
start_timestamp/end_timestampfromTimeseriesMetricas it is not clear how it will be used. Can add later if needed.