Add disconnect reason for SIP failures. #845
Conversation
🦋 Changeset detectedLatest commit: 66e07e0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
protobufs/livekit_models.proto
Outdated
| @@ -447,6 +447,8 @@ enum DisconnectReason { | |||
| USER_UNAVAILABLE = 11; | |||
| // SIP callee rejected the call (busy) | |||
| USER_REJECTED = 12; | |||
| // SIP protocol failure or unexpected response | |||
| USER_FAILURE = 13; | |||
There was a problem hiding this comment.
do you have some examples of how this would fail? USER_FAILURE seems too generic.. and it seems like it's not an explicit user action
There was a problem hiding this comment.
A typical failure would be the SIP server we are trying to dial rejecting our request (e.g. wrong password, wrong number, etc).
Agree, the name is not the best one. I considered EXTERNAL_FAILURE, INTEGRATION_FAILURE or CONNECTOR_FAILURE to indicate that it's not an issue with LiveKit, but with the external service.
There was a problem hiding this comment.
That would work, but we specifically omitted SIP_ prefix in other cases. Maybe we could also use a name that could be reused for other integrations?
There was a problem hiding this comment.
yeah, the other ones (USER_REJECTED, USER_UNAVAILABLE) indicate user action. it seems correct.
in this case, it seems like it is an issue with the sip trunk, so feels like we should reflect it as is, instead of additional abstractions
There was a problem hiding this comment.
Changed to SIP_TRUNK_FAILURE.
dennwc
force-pushed
the
sip-failed-call-state
branch
from
5ab52ef to
67c5b09
Compare
dennwc
force-pushed
the
sip-failed-call-state
branch
from
07a9c43 to
66e07e0
Compare
We can now indicate that LiveKit participant associated with SIP has left particularly because of a SIP protocol failure.