Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): bump go to 1.23" #905

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

davidzhao
Copy link
Member

@davidzhao davidzhao commented Nov 28, 2024

Reverts #885

Since this package is depended on by others (including external users). we should not raise Go version requirements too aggressively.

Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 4d748b1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@davidzhao davidzhao requested review from rektdeckard and a team November 28, 2024 18:18
@rektdeckard
Copy link
Contributor

I believe the bump was to fix build issues in some part of closed-source due to dependency on 1.23 features (indirectly). It may be a dependency we can replace, though.

@davidzhao
Copy link
Member Author

I believe the bump was to fix build issues in some part of closed-source due to dependency on 1.23 features (indirectly). It may be a dependency we can replace, though.

I think it's a dependency for counterfeiter/v6, it's compiling now after I lowered the version.. let's see if downstream deps would error again

@davidzhao davidzhao merged commit 2d25b79 into main Nov 29, 2024
3 checks passed
@davidzhao davidzhao deleted the revert-885-tobias/go-bump branch November 29, 2024 06:35
@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants