Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/install: Add recommended installation step using the install.sh script #184

Merged
merged 2 commits into from
May 11, 2022
Merged

docs/install: Add recommended installation step using the install.sh script #184

merged 2 commits into from
May 11, 2022

Conversation

hjpotter92
Copy link
Member

@vercel
Copy link

vercel bot commented Mar 11, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/livepeer/docs/84XZhQ2c1sjxYTza29x1ZvqW3d8Z
✅ Preview: https://docs-git-hjp-installation-livepeer.vercel.app

@hjpotter92 hjpotter92 mentioned this pull request Mar 11, 2022
Merged
hthillman
hthillman reviewed Mar 11, 2022
View reviewed changes
Copy link
Contributor

@hthillman hthillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me, is this a new installation step or one that we just haven't documented?

@hjpotter92
Copy link
Member Author

Overall this looks good to me, is this a new installation step or one that we just haven't documented?

the gpg verification/generation would be available after livepeer/go-livepeer#2282 gets merged. the script itself still exists, just undocumented.

@vercel vercel bot temporarily deployed to Preview March 14, 2022 05:11 Inactive
@hthillman
Copy link
Contributor

@hjpotter92 is this good to go? looks like the underlying PR is merged

@hjpotter92
Copy link
Member Author

@hjpotter92 is this good to go? looks like the underlying PR is merged

Yes! I was hoping to have it merged after a new release was created for go-livepeer.

@thomshutt thomshutt merged commit 49d365b into main May 11, 2022
@thomshutt thomshutt deleted the hjp/installation branch May 11, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hthillman hthillman hthillman left review comments

@thomshutt thomshutt thomshutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjpotter92 @hthillman @thomshutt