fixup! eth: fix max gas price nil pointer error in replace transaction

livepeer · Sep 2, 2021 · 9aa366c · 9aa366c
1 parent c003537
commit 9aa366c
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/eth/transactionManager_test.go b/eth/transactionManager_test.go
@@ -209,7 +209,6 @@ func TestTransactionManager_Replace(t *testing.T) {
 	)
 
 	// Error signing replacement tx
-	gpm.maxGasPrice = nil
 	expErr = errors.New("SignTx error")
 	sig := &stubTransactionSigner{
 		err: nil,
@@ -222,6 +221,12 @@ func TestTransactionManager_Replace(t *testing.T) {
 	assert.EqualError(err, expErr.Error())
 	sig.err = nil
 
+	// Test when max gas price is nil - should still return signing replacement tx error
+	gpm.maxGasPrice = nil
+	tx, err = tm.replace(stubTx)
+	assert.Nil(tx)
+	assert.EqualError(err, expErr.Error())
+
 	// Error sending replacement tx
 	expErr = errors.New("SendTx error")
 	eth.err["SendTransaction"] = expErr