darwin: Fix builds with libtasn1 patch for gnutls #1789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
force-pushed
the
yf/fix-darwin-build
branch
from
7ea7c6a to
540ab02
Compare
|
I'm super confused why this fails at link-time rather than compile-time. And... what, libtasn1 has been broken on Darwin for nearly a year? How does that happen? |
|
Superseded by #1795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes the broken Darwin build by applying a libtasn1 patch for gnutls.
Darwin builds started failing after the gnutls version was bumped in #1785. The failure did not occur at compile time for gnutls because
install_ffmpeg.shcompiles gnutls using the--disable-docflag and instead it occurred when attempting to link ffmpeg with gnutls. The ffmpeg build then fails with:tail -n 100 ~/ffmpeg/ffbuild/config.logshowed more information about the error.The error encountered is captured by this gnutls issue. The issue is closed, but the fix does not appear to be shipped with gnutls 3.7.0 yet though. But, a patch was shared in that issue thread and an example of that patch being applied can be found here.
Specific updates (required)
See commit history.
How did you test each of these updates (required)
Successfully created a Darwin build locally.
Now let's see if the Travis build succeeds...
Update: It did! 🥳
Does this pull request close any open issues?
Fixes #1788
Checklist:
./test.shpass