.github/workflows: checkout action use head commit #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
force-pushed
the
yf/fix-ci-hash
branch
2 times, most recently
from
7045a2d to
3652159
Compare
|
@yondonfu windows build still has wrong hash |
@darkdarkdragon Should be fixed by c240ef9 and 5feadf5. |
hjpotter92
added a commit
that referenced
this pull request
Mar 15, 2022
hjpotter92
added a commit
to livepeer/livepeer-data
that referenced
this pull request
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Always checkout the head commit for GH actions.
When a
pull_requestevent triggers a GH action, the@actions/checkoutaction will checkout from the repo using the value ofgithub.ref. The value ofgithub.refin this scenario is the SHA hash of the merge commit that is created by merging the base to the head. The problem with this is that the merge commit hash will be referenced in the go-livepeer version string, but the merge commit might not be present in the commit history (see #1887) which makes it difficult to debug builds.Specific updates (required)
Set
github.refto the SHA of the head commit when checking out.How did you test each of these updates (required)
Ran CI.
Does this pull request close any open issues?
Fixes #1887
Checklist:
makeruns successfully./test.shpassPending changelog updated