Should not save (when recording) segments with zero video frames #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iameli
reviewed
Jun 10, 2021
server/broadcast.go
Outdated
| glog.Warningf("Error checking for zero video frame nonce=%d manifestID=%s name=%s bytes=%d took=%s err=%v", | ||
| nonce, mid, name, len(seg.Data), time.Since(now), err) | ||
| } else { | ||
| glog.Infof("Checking for zero video frame nonce=%d manifestID=%s name=%s bytes=%d took=%s returned res=%v", |
There was a problem hiding this comment.
This'll log every segment, yeah? Seems like it could be a glog.Debugf at least.
There was a problem hiding this comment.
Good point. Moved it around so it will show only for 0-frame segments.
darkdarkdragon
force-pushed
the
it/zero-video-no-save
branch
from
b6841a0 to
65c7146
Compare
yondonfu
approved these changes
Jun 16, 2021
| @@ -386,6 +386,19 @@ func processSegment(cxn *rtmpConnection, seg *stream.HLSSegment) ([]string, erro | |||
| if ros != nil { | |||
| go func() { | |||
| now := time.Now() | |||
| hasZeroVideoFrame, err := ffmpeg.HasZeroVideoFrameBytes(seg.Data) | |||
There was a problem hiding this comment.
I see that this function was added in livepeer/lpms#237 and it returns an integer. Fine for now since that PR was already merged, but I think returning a boolean would make this function more straightforward to use and suggest making that change separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Do not save segments with zero video frame to record store.
Specific updates (required)
Check segment before saving using
lpmg.HasZeroVideoFrameBytesfunction.How did you test each of these updates (required)
Unit test
Does this pull request close any open issues?
Fixes #1888
Checklist:
makeruns successfully./test.shpass