Session tear down logic for fast verification

[cyberj0g]

What does this pull request do? Explain your changes. (required)

Implementation of session tear down logic as part of verification process #2323

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

• Read the contribution guide
• make runs successfully
• All tests in ./test.sh pass
• README and other documentation updated
• Pending changelog updated

[cyberj0g]

That's still work in progress, adding the tests next. @yondonfu could you please have a quick look and maybe suggest some improvements, as you are the only person available who originally worked on this logic?
CC: @thomshutt @AlexKordic @oscar-davids

[yondonfu]

For my own understanding:

Is the reason why we don't send an EndSessionRequest to O when we cleanup the session on B due to inactivity [1] because we expect that O would have timed out the session on its end at that point as well?

[1] I think here

go-livepeer/server/mediaserver.go

Line 879 in e3f9286

_ = removeRTMPStream(ctx, s, extmid)

at least for HTTP push?

[cyberj0g]

@yondonfu thanks for comments and insights, all addressed.

Is the reason why we don't send an EndSessionRequest to O when we cleanup the session on B due to inactivity [1] because we expect that O would have timed out the session on its end at that point as well?

I think it's a good idea to signal tear down there as well.

[codecov]

Codecov Report

Merging #2381 (1e57385) into master (a7c8244) will decrease coverage by 0.01501%.
The diff coverage is 43.41085%.

@@                 Coverage Diff                 @@
##              master       #2381         +/-   ##
===================================================
- Coverage   56.47655%   56.46154%   -0.01502%     
===================================================
  Files             88          88                 
  Lines          18760       18850         +90     
===================================================
+ Hits           10595       10643         +48     
- Misses          7585        7629         +44     
+ Partials         580         578          -2     

Impacted Files	Coverage Δ
cmd/livepeer/starter/starter.go	2.29008% <0.00000%> (ø)
core/livepeernode.go	71.05263% <ø> (ø)
core/transcoder.go	32.22506% <0.00000%> (-0.67312%)	⬇️
server/ot_rpc.go	35.34483% <0.00000%> (-0.41098%)	⬇️
server/router.go	0.00000% <0.00000%> (ø)
core/lb.go	79.04192% <6.66667%> (-7.14229%)	⬇️
core/orchestrator.go	77.49648% <46.15385%> (-1.26076%)	⬇️
server/rpc.go	71.38643% <48.38710%> (-0.78185%)	⬇️
server/broadcast.go	77.87611% <90.00000%> (+0.66431%)	⬆️
server/mediaserver.go	67.28972% <100.00000%> (+0.46729%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c8244...1e57385. Read the comment docs.

Impacted Files	Coverage Δ
cmd/livepeer/starter/starter.go	2.29008% <0.00000%> (ø)
core/livepeernode.go	71.05263% <ø> (ø)
core/transcoder.go	32.22506% <0.00000%> (-0.67312%)	⬇️
server/ot_rpc.go	35.34483% <0.00000%> (-0.41098%)	⬇️
server/router.go	0.00000% <0.00000%> (ø)
core/lb.go	79.04192% <6.66667%> (-7.14229%)	⬇️
core/orchestrator.go	77.49648% <46.15385%> (-1.26076%)	⬇️
server/rpc.go	71.38643% <48.38710%> (-0.78185%)	⬇️
server/broadcast.go	77.87611% <90.00000%> (+0.66431%)	⬆️
server/mediaserver.go	67.28972% <100.00000%> (+0.46729%)	⬆️
... and 3 more

[oscar-davids]

LGTM!