-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include lpms min enc resolution #2466
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2466 +/- ##
===================================================
- Coverage 54.86667% 54.84901% -0.01766%
===================================================
Files 94 94
Lines 19726 19736 +10
===================================================
+ Hits 10823 10825 +2
- Misses 8306 8313 +7
- Partials 597 598 +1
Continue to review full report at Codecov.
|
CHANGELOG_PENDING.md
Outdated
@@ -15,6 +15,7 @@ | |||
#### Transcoder | |||
|
|||
### Bug Fixes 🐞 | |||
- [task-runner \#24](https://github.com/livepeer/task-runner/issues/24) rendition resolution fix for portrait input videos; Min resolution applied for Nvidia hardware (@AlexKordic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this link to the PR rather than / as well as the issue it fixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, being another project. What do you think how to verbalize this item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that is a little unusual - I think include the PR ID at the start like normal and then have the task-runner URL somewhere in the message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed to look normal
What does this pull request do? Explain your changes. (required)
Include changes from PR 326.
Specific updates (required)
GetCodecInfoBytes()
to match return types.How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
make
runs successfully./test.sh
pass