server: Enforce a minimum timeout for segment upload #2541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is to fix the segment upload timeout for really short segments, which I
found to be an issue when investigating frequent timeouts in VOD tests.
In this case (logs), there is a frequent
header timeout
happening in the tests,and even by increasing the retries and adding some backoff logic, it seems to keep
happening pretty often.
I then noticed that it always happened with the same segment of the test video, and
when segmenting it locally with the same code I found that this segment has a duration
of
533ms
(and only so short cause it's the last seg in the file).This means that the upload timeout given to it would be a mere
250ms
, whichcan easily be hit for longer round-trip times to orchestrators even if they would be able to
respond healthily.
Specific updates (required)
MinSegmentUploadTimeout
be a minimum instead of just a defaultHow did you test each of these updates (required)
Ran automatic tests.
Does this pull request close any open issues?
No.
Checklist:
make
runs successfully./test.sh
pass